• Revised I-D Needed - Issue raised by WG
  • Awaiting Expert Review/Resolution of Issues Raised
  • Awaiting External Review/Resolution of Issues Raised
  • Awaiting Merge with Other Document
  • Author or Editor Needed
  • Waiting for Referenced Document
  • Waiting for Referencing Document
  • Revised I-D Needed - Issue raised by WGLC
  • Revised I-D Needed - Issue raised by AD
  • Revised I-D Needed - Issue raised by IESG
  • Doc Shepherd Follow-up Underway
  • Other - see Comment Log

IETF :: codec

Current state: Submitted to IESG for Publication

Viewing the last 20 entries. Show full log.

(System)

RFC published

Cindy Morgan

State changed to RFC Ed Queue from Approved-announcement sent

(System)

IANA Action state changed to No IC

Amy Vezza

State changed to Approved-announcement sent from Approved-announcement to be sent

Amy Vezza

IESG has approved the document

Amy Vezza

Closed "Approve" ballot

Amy Vezza

Ballot approval text was generated

Amy Vezza

State changed to Approved-announcement to be sent from IESG Evaluation::AD Followup

Robert Sparks

Ballot writeup was changed

Jean-Marc Valin

New revision available

Stewart Bryant

[Ballot comment]
I am clearing my discuss on the agreement that text similar to the following will be added to header of the files:

"This file is extracted from RFCXXXX. Please see that RFC for additional information."

Where XXXX will be replaced by the actual RFC number.

I understand similar but more grammatically appropriate text will be added to the README file.

Stewart Bryant

[Ballot Position Update] Position for Stewart Bryant has been changed to No Objection from Discuss

Pete Resnick

[Ballot comment]
Glad to see the updated copyright statements. Thanks.

As I stated earlier, the files in the git repository cited in the document probably also should have the IETF Trust copyright. Moreover, I would prefer to see the repository hosted on an IETF site rather than on xiph.org. I am concerned about drift of the code on xiph from the code in the RFC and ending up in a situation where the xiph version is -- de facto -- the place to go for the standard.

Like others, I don't feel I can give a substantive review to much of this document and will simply trust that it has gotten sufficient review. The one technical thing I noticed: A few variables that need to be unsigned because they're used in shift right (>>) operations are not explicitly specified as unsigned, in particular ft (used in 4.1.5) and b0 (used in 4.1.1). You do note other variables as unsigned, so I took these as omissions, but it may be clear from context. It seems to me a review of such variables might be useful.

Like other ADs, I have some concerns about the use of source code for the normative spec:

- First of all, this does turn the entire concept of "independent interoperable implementations" on its head. If the source code is normative, I don't see how we could ever judge that an implementation was independent and therefore how this spec would be advanced along the standards track.

- Furthermore, I've got some concerns that we may, at some point in the future, encounter a small edge case where the code simply has a bug, but the text of the document makes it clear what the intention was. I would hate for us to say, "Well, the code is the normative reference, so the bug must stand and we must update the descriptive text to suit." I doubt that would happen, but we are in unchartered waters by using source as the normative spec.

- Finally, the source code here is in base64, compressed, tarred format. It is completely unreadable in the spec. I do not know of any other RFC that has humanly-unreadable text in it. Again, we are in completely unchartered waters.

And it is these "unchartered waters" that are the real issue all around. We may need to discuss how we handle this document now and in the future. But we signed up for this in the charter, so I'm willing to see it play out. There is no doubt that this document is an entirely odd duck.

Pete Resnick

[Ballot Position Update] Position for Pete Resnick has been changed to No Objection from Discuss

Sean Turner

[Ballot Position Update] Position for Sean Turner has been changed to No Objection from Discuss

Stephen Farrell

[Ballot comment]

- I agree that Pete's discuss needs to be resolved. It may be
that there's a way to do that without the IETF trust owning the
code, I don't know. I did also note that celt/pitch.c also has a
CSIRO copyright from 2007-2008. Were people from CSIRO involved
in the WG? If so, does whatever code is involved constitute an
IETF contribution (I would think so) and has someone checked
that no IPR declarations from CSIRO are needed? (Same question
applies for all such contributors.) This is (I think) a varition
on Pete's discuss since I guess that people from Xiph and Skype
(the examples he quoted) have been involved in this work so any
IPR declartions from them will have been done already.

- If code comments conflict with the text of the body of the
draft, then which is normative? Its clear that code wins but I'm
not sure about comments within the code. I'm ok with any
reasonable answer here, but wanted to check.

- The code contains things like "#ifdef FIXED_POINT" which is
commented out in the top level Makefile. If the normative
specification is the source code, what is the normative status
of code that's only conditionally compiled and that is not
compiled with the distributed Makefile? Have all such
conditionally compiled code fragments been tested to the same
extent as the code that is compiled with the default Makefile?
I'm ok with any reasonable answer here, but wanted to check.

- I think a few references to introductory materials about
codecs would be useful in the intro for the poor victim^Wreader
who's handed this and told to implement or optimise opus.

- p13, [SRTP-VBR], RFC 6562, says that VBR SHOULD NOT be used
for "highly sensitive" voice and goes on to say that VBR is ok
if you're just matching the bandwidth but maybe not if the
variation is driven by the speech signal. I think it'd be good
to note both of those aspects here. I'd also personally prefer
if both 6562 and this said "possibly sensitive" rather than
"highly sensitive" since I don't know how code at this layer
could know what's really sensitive or not. This might also be
worth repeating in (or moving to) the security considerations as
well as it would perhaps be more visible there.

nits

- p28, says "This same data MUST also be returned as raw bits
when requested." Requested by whom? I didn't get that.

- p30, says "this draft" s/draft/memo/ or whatever

- p31, says "SHOULD take measures to conceal the error" but
doesn't say what those might be

- p32, all those "1/8th bit" phrases read oddly to me but maybe
that's standard fare for codec folks.

- p151, says that padding is used in CBR mode but doesn't seem
to say what kind of padding. If its the same as for my discuss
(i.e. zero padding) then maybe the same considerations apply
here? (Not sure)

Stephen Farrell

[Ballot Position Update] Position for Stephen Farrell has been changed to No Objection from Discuss

(System)

Sub state has been changed to AD Followup from Revised ID Needed

Jean-Marc Valin

New revision available

Cindy Morgan

State changed to IESG Evaluation::Revised ID Needed from IESG Evaluation

Viewing the last 20 entries. Show full log.