Skip to main content

The 'sip-trunking-capability' Link Relation Type
draft-ietf-asap-siptrunkingcapability-link-05

Yes

Murray Kucherawy

No Objection

Erik Kline
Jim Guichard
John Scudder
Paul Wouters
(Andrew Alston)

Note: This ballot was opened for revision 03 and is now closed.

Comment (2023-04-12 for -03) Not sent
Thank you to Chris Wood for the SECDIR review.
Comment (2023-04-12 for -03) Sent
Thank you for writing this document.

Also thanks to Joe Clarke for his OpsDir review: https://datatracker.ietf.org/doc/review-ietf-asap-siptrunkingcapability-link-03-opsdir-lc-clarke-2023-03-10/ , and discussions on it.
Comment (2023-04-07 for -03) Sent
Thanks for the work done in this document.

Some comments though:

1) is "an enterprise telephony SIP" defined and accepted in the SIP community ? (I refer here to "enterprise" 

2) the abstract starts with "This specification defines", is an informational document a specification ?

3) s/https://capserver.ssp1.com/capserver/capdoc.json/https://capserver.ssp1.example.com/capserver/capdoc.json/

Hope this helps to improve the document,

Regards

-éric
No Objection (for -03) Not sent

                            
No Objection (2023-04-12 for -03) Sent
# GEN AD review of draft-ietf-asap-siptrunkingcapability-link-03

CC @larseggert

Thanks to Dan Romascanu for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/cCbhIYhRA9a5A5cetapDsKTttmE).

## Comments

### Section 3, paragraph 4
```
                "href" :"https://capserver.ssp1.com/capserver/capdoc.json"
```
Please use an example domain here.

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### URLs

These URLs in the document did not return content:

 * https://capserver.ssp1.com/capserver/capdoc.json

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool
No Objection (2023-04-12 for -03) Sent
Hi,

Thanks for this short document.

From reading this document, it wasn't clear to me as to what the exact relationship is between this document and I-D.ietf-asap-sip-auto-peer.  Specifically, is I-D.ietf-asap-sip-auto-peer just an example of what might be found using 'sip-trunking-capability' or is it the only capability document that would expect to be found at that location?  Based on the answer to this question, it might be helpful for the text in section 4 to be more proscriptive of the relationship, and perhaps check that the text is section 1 and 2 also describes this clearly.

In terms of document process, I was slightly surprised to see:
(a) this as Informational rather than Standards Track - I guess that Informational is sufficient, but Standards Track may have been clearer to a reader;
(b) that ietf-asap-sip-auto-peer is only an informative reference rather than a normative reference (which goes back to my original question above);
(c) this as a separate document to ietf-asap-sip-auto-peer, which also goes back to my original question above.

Regards,
Rob