vCard Format Extension for JSContact
draft-ietf-calext-vcard-jscontact-extensions-12

The working group substate indicates "Document shepherd follow-up underway".  Hopefully that's not still the case.  Also "yes" isn't a great answer to #1 on the shepherd writeup.  And for #11, it's not the case that only standards track documents can specify things for interoperability.

In Section 2.1, an example using TYPE would be helpful.

The SHOULD in Section 2.3 could use some support.  What's a legitimate reason not to do what it says?  If there isn't one, should it be a MUST?

Same question about the SHOULD in Section 2.6.

Thanks for addressing my discusses

Thanks for working on this specification. I didn't find any transport protocol related issue :-). 

However, I started to wonder about one thing - what would happen when JScontact get extended, would that mean vcard would also need to be extended to "align the same set of features". what is the deal here and how long we should do the alignment?

# GEN AD review of draft-ietf-calext-vcard-jscontact-extensions-05

CC @larseggert

## Comments

### Missing "Updates" explanation

This document updates RFC6350, but does not seem to include explanatory text
about this in the abstract.

### Section 2.6, paragraph 11
```
     Example(s):
        SOCIALPROFILE;SERVICE-TYPE=Twitter:https://twitter.com/ietf
        SOCIALPROFILE:https://github.com/github
        SOCIALPROFILE;SERVICE-TYPE=SomeSite;VALUE=TEXT:peter94
```
Please use example domains here.

### Section 3.7, paragraph 6
```
     Example(s):
        SOCIALPROFILE;SERVICE-TYPE=Twitter:https://twitter.com/ietf
```
Please use an example domain here.

### Uncited references

Document updates `RFC6350`, but does not cite it as a reference, which is a bit
odd.

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Outdated references

Document references `draft-ietf-calext-jscontact-08`, but `-09` is the latest
available revision.

Document references `draft-ietf-calext-jscontact-vcard-06`, but `-07` is the
latest available revision.

### Grammar/style

#### Section 2.5, paragraph 3
```
ty with URI values, it also allows to set usernames for social media service
                                   ^^^^^^
```
Did you mean "setting"? Or maybe you should add a pronoun? In active voice,
"allow" + "to" takes an object, usually a pronoun.

#### Section 2.5, paragraph 9
```
, the AUTHOR-NAME parameter allows to name an author as free-text value (see 
                                   ^^^^^^^
```
Did you mean "naming"? Or maybe you should add a pronoun? In active voice,
"allow" + "to" takes an object, usually a pronoun.

#### Section 2.6, paragraph 6
```
ter, the AUTHOR parameter allows to identify an author by URI (see Section 3
                                 ^^^^^^^^^^^
```
Did you mean "identifying"? Or maybe you should add a pronoun? In active voice,
"allow" + "to" takes an object, usually a pronoun.

#### Section 2.6, paragraph 11
```
ange resembles an update or rather a delete and create. Format definition: cr
                                   ^^^^^^^^
```
After "a", the verb "delete" doesn't fit. Is "delete" spelled correctly? If
"delete" is the first word in a compound adjective, use a hyphen between the
two words. Using the verb "delete" as a noun may be non-standard.

#### Section 3.2, paragraph 3
```
Description: The RANKS parameter on a N property assigns a rank among the sa
                                    ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 3.2, paragraph 3
```
ong the same-typed name components of a N property value. Some cultures assi
                                      ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 3.2, paragraph 3
```
e N property value does not allow to infer a culturally or otherwise signifi
                                  ^^^^^^^^
```
Did you mean "inferring"? Or maybe you should add a pronoun? In active voice,
"allow" + "to" takes an object, usually a pronoun.

#### Section 3.2, paragraph 4
```
 structurally equivalent to the multi-valued N property value: ranks of diff
                                ^^^^^^^^^^^^
```
This word is normally spelled as one.

#### Section 3.2, paragraph 5
```
component types are separated by semi-colon, ranks among the same name compo
                                 ^^^^^^^^^^
```
This word is normally spelled as one.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool

Hi,

Not flagging this as a discuss because I've not checked closely enough that these are actual mistakes, but there were a couple of instances of the formal definition which were surprising to me:

Moderate level comments:

(1) p 8, sec 2.6.  SOCIALPROFILE Property

      socialpr-param = "VALUE=uri" / "VALUE=text" /
                       service-type-param / any-param

Is the text case insensitive?  I note that you ahve "VALUE=text" in the ABNF above, but "VALUE=TEXT" is the example below.


(2) p 12, sec 3.7.  SERVICE-TYPE Parameter

   Format definition:
      service-type-param    = param-value

Is this format definition right (or otherwise, I'm not sure I understand the examples here and in 2.6)?  Shouldn't it include "SERVICE-TYPE" "=" param-value?


Regards,
Rob