Skip to main content

Negative Caching of DNS Resolution Failures
draft-ietf-dnsop-caching-resolution-failures-08

Yes

(Warren Kumari)

No Objection

Jim Guichard
Roman Danyliw
(Andrew Alston)
(John Scudder)

Note: This ballot was opened for revision 07 and is now closed.

Éric Vyncke
Yes
Comment (2023-09-07 for -07) Sent
# Éric Vyncke, INT AD, comments for draft-ietf-dnsop-caching-resolution-failures-07

Thank you for the work put into this document. It should indeed be VERY useful !

Please find belowsome non-blocking COMMENT points (but replies would be appreciated even if only for my own education).

Special thanks to Andrew McConachie for the shepherd's write-up *but it lacks* the justification of the intended status. 

Other thanks to Carlos Pignataro , the Internet directorate reviewer, please consider this int-dir review:
https://datatracker.ietf.org/doc/review-ietf-dnsop-caching-resolution-failures-07-intdir-telechat-pignataro-2023-09-06/ (I have read Duane's reply, thanks)

Other thanks to Peter van Dijk, the DNS directorate reviewer, please consider this dns-dir review (as a follow-up of his Last Call review):
https://datatracker.ietf.org/doc/review-ietf-dnsop-caching-resolution-failures-07-dnsdir-telechat-van-dijk-2023-09-04/

I hope that this review helps to improve the document,

Regards,

-éric

# COMMENTS

## Abstract

`RFC 2308 specifies requirements for DNS negative caching` should this statement only apply to (2) responses and not (1) responses (as this would be positive caching) ?

## Section 2.2 (and other places)

Is there a reason why EXAMPLE.COM is in uppercase in the text ? This is really unusual.

Please follow RFC 5952 and write IPv6 address is lower case (BTW thanks for using modern addressing)
Jim Guichard
No Objection
Roman Danyliw
No Objection
Paul Wouters Former IESG member
Yes
Yes (2023-09-06 for -07) Sent
Thanks for this document and my apologies for being involved/related to two
of the five outages you described :-)


        Consistent with [RFC2308], resolution failures MUST NOT be cached
        for longer than 5 minutes.

If an expired RRSIG has a TTL of 3600, what should happen? The resolution
failed because the signature is no longer valid but the individual
components of this validation failure are all successful lookups of RRs that
are now in the cache.  Wouldn't this result in a resolution failure of
3600? How would an implementation limit this to 5 minutes? By deleting
the RRSIG from its cache within 5 minutes, overriding its TTL?

If so, is there value stating this in the document?


        also known as 'lame'

I thought the WG agreed the definition of 'lame' was not agreed upon and
the term is no longer being favoured for use. Why not just remove this part?

        To prevent such unnecessary DNS traffic, security-aware resolvers
        MUST cache DNSSEC validation failures, with some restrictions.

What are these "some restrictions" ?
Robert Wilton Former IESG member
Yes
Yes (2023-09-05 for -07) Sent
Hi,

Thanks for working on this document - I'm not a DNS expert but it looks like good advice.

A couple of minor comments for your consideration:

(1) p 2, sec 1.  Introduction

   This document updates [RFC2308] to require negative caching of DNS
   resolution failures and provides additional examples of resolution
   failures.

Perhaps "caching of all DNS resolution failures"?


(2) p 2, sec 1.1.  Motivation

   RFC Editor: We'd like your thoughts on moving the Motivation and
   Related Work sections to appendices.  Is that a preferred style?

Not the RFC editor, but I would keep the motivation here, as a subsection of the introduction.

Regards,
Rob
Warren Kumari Former IESG member
Yes
Yes (for -07) Unknown

                            
Andrew Alston Former IESG member
No Objection
No Objection (for -07) Not sent

                            
Erik Kline Former IESG member
No Objection
No Objection (2023-08-27 for -07) Sent
# Internet AD comments for draft-ietf-dnsop-caching-resolution-failures-07
CC @ekline

* comment syntax:
  - https://github.com/mnot/ietf-comments/blob/main/format.md

* "Handling Ballot Positions":
  - https://ietf.org/about/groups/iesg/statements/handling-ballot-positions/

## Nits

### S1.2

* "only exacerbated" -> "further exacerbated"?

  Use of "only" here might be misread.

### S2.2

* s/2001:DB8:1::/2001:db8:1::/g

  in accordance with RFC 5952 section 4.3
Francesca Palombini Former IESG member
No Objection
No Objection (2023-09-07 for -07) Not sent
Thank you for the work on this document.

Many thanks to Barry Leiba for his ART ART review: https://mailarchive.ietf.org/arch/msg/art/BjJLwKrE6OU3wpXDUbe6rq8288w/, and to the authors for addressing it.
John Scudder Former IESG member
No Objection
No Objection (for -07) Not sent

                            
Murray Kucherawy Former IESG member
No Objection
No Objection (2023-09-06 for -07) Sent
Thanks to Barry Leiba for his ARTART review.

I think the SHOULD in Section 3.2, paragraph 2, is not appropriate use of SHOULD as it doesn't address interoperability or operations or security recommendations.  A regular "should" is fine.

Apart from that, this looks like it's in good shape.
Zaheduzzaman Sarker Former IESG member
No Objection
No Objection (2023-09-07 for -07) Sent
Thanks for working on this specification. My review does yield any TSV related issues.

I have following minor comments that I believe will improve the document quality when addressed -

  # While this specification updates RFC2308, RFC4038 and RFC4697, the Introduction section only mentions RFC2308. Would be good to give emphasis on all the updates.

  # Regarding Motivation section, I like the motivation section up front and understanding of the problem to solve before going into solution description. So I would like to keep this section where it is.

  # Section 2 says - 

        If any one of the available servers provides a useful response, then it is not considered a resolution failure. 

    with that I am not sure why responses in section 2.1 and 2.2 are qualified as useful responses. Please add some clarification texts in those sections.