Segment Routing Segment Types Extensions for BGP SR Policy
draft-ietf-idr-bgp-sr-segtypes-ext-08

Thanks to Vincent Roca for his secdir review. 

I agree with the following John Scudder's wording comments.  
  - titles of the subsections:  I did find myself scrolling up and down to remember which letter went with which option.  
  - Flags are set or clear (picky, maybe but precise language helps the implementer)

Thank you to complete the encoding of these segment types with BGP.

One small editorial observation was that sometimes a dash "-" is used between specifying the number of octets and sometimes it is not. for example "4 octets" or "16-octets"

Thanks for your work on this document. I have a few comments I hope are helpful.

- It would be nice if the subsection titles included both the letter code and the symbolic name. (Contrast to my comment on the document draft-ietf-idr-bgp-ls-sr-policy-13, which uses only the symbolic name and not the letter code, which I also found suboptimal.)

- You use verbiage following this pattern in several places: "SR Algorithm: 1 octet specifying SR Algorithm as described in section 3.1.1 in [RFC8402] when A-Flag as defined in Section 2.10 is present. SR Algorithm is used by SRPM [I-D.ietf-idr-sr-policy-safi] as described in section 4 in [RFC9256]. When A-Flag is not encoded". While I'm able to understand what you mean by the flag being "present" or "not encoded", strictly speaking, it doesn't make sense: a flag is always present, the distinction is whether it's set or clear. Referring back to ls-sr-policy again, that document says "The document uses the term "set" to indicate that the value of a flag bit is 1 and the term "clear" when the value is 0." I think you would do well to adopt the same convention here and expunge any "present" and "not encoded" when talking about flags.

- Similar to the above, you use "appears with" 3x in Section 2.10, e.g. "A-Flag applies to Segment Types C, D, I, J, and K. If A-Flag appears with Segment Types A, B, E, F, G, and H, it MUST be ignored." A similar critique applies. I think you can instead say something like "the value of the A-Flag is ignored for Segment Types A, B, E, F, G, and H".