Dynamic subscription to YANG Events and Datastores over RESTCONF
draft-ietf-netconf-restconf-notif-15

Note: This ballot was opened for revision 13 and is now closed.

Ignas Bagdonas Yes

Deborah Brungard No Objection

Alissa Cooper No Objection

Comment (2019-05-14 for -13)
= Section 9 =

	"Access control must be set so that only someone
      with proper access permissions, and perhaps even HTTP session has
      the ability to access this resource."
    
There is a grammar error in this sentence -- "perhaps even HTTP session" doesn't follow from the antecedent.

Roman Danyliw (was Discuss) No Objection

Comment (2019-06-10 for -14)
Thank you for addressing my DISCUSS and COMMENTs.

Benjamin Kaduk (was Discuss) No Objection

Comment (2019-06-13)
Thank you for addressing my Discuss points!

Suresh Krishnan No Objection

Mirja Kühlewind No Objection

Comment (2019-05-13 for -13)
One question (and this is probably just because of my lack of detailed knowledge about RESTCONF):

Sec 4 says: "To meet subscription quality of service promises, the publisher MUST
   take any existing subscription "dscp" and apply it to the DSCP
   marking in the IP header."
What does "existing subscription "dscp"" mean here?

Related update: please also consider the comment from the TSV-ART review about the example DSCP value (Thanks Wes!). I actually would also appreciate to add a comment that this is an internal value that depends on the network configuration (in order to avoid that people just randomly copy this example value and suddenly always use 10)!

Barry Leiba No Objection

Comment (2019-05-15 for -13)
I support Adam’s DISCUSS point on Section 3.3.

Alexey Melnikov No Objection

Alvaro Retana No Objection

Adam Roach (was Discuss) No Objection

Comment (2019-07-26)
Thanks for addressing my discuss points!

Martin Vigoureux No Objection

Éric Vyncke No Objection

Magnus Westerlund No Objection

Comment (2019-05-16 for -13)
Section 4:

Based on the QoS discussion for draft-ietf-netconf-subscribed-notifications weight is not really a a priority in the terms people think of it. It only provides a weight for bandwidth allocation. 

   o  take any existing subscription "priority", as specified by the
      "weighting" leaf node in
      [I-D.draft-ietf-netconf-subscribed-notifications], and copy it
      into the HTTP2 stream weight, [RFC7540] section 5.3, and

I would recommend that the use of "priority" is reformualted here to reflect that aspect. 


   o  take any existing subscription "dependency", as specified by the
      "dependency" leaf node in
      [I-D.draft-ietf-netconf-subscribed-notifications], and use the
      HTTP2 stream for the parent subscription as the HTTP2 stream
      dependency, [RFC7540] section 5.3.1, of the dependent
      subscription.

What is not obivous to me is that just because that a subscription exists at the publisher that it is going over the same HTTP/2 connection and thus there might be nothing for the dependency to point at that is relevant for the mechanism described in RFC 7540. I didn't even find a recommendation that the receiver (subscriber) should actually re-use the HTTP/2 connection for all communication with the same publisher.