The SEED Cipher Algorithm and Its Use with IPsec
draft-lee-ipsec-cipher-seed-01

IANA Comments:
Upon approval of this document the IANA will assign a ESP Transform Identifier for ESP_SEED_CBC.  This registration will take place in the following registry:
<http://www.iana.org/assignments/isakmp-registry>

[Ballot comment]
The abstract uses IV without expanding it to initialization vector; it might
be clearer to expand on it, since this is the first use in this document.

[Ballot comment]
Small note from Spencer Dawkins:

This document does still contain two fairly important references to web pages in the body of the draft:

- http://www.kisa.or.kr/seed/seed_eng.html and
- http://www.kisa.or.kr/seed/seed_eng.html,

plus several more in the references section.

Assuming that ftp://ftp.rfc-editor.org/in-notes/rfc-editor/instructions2authors.txt is current, today's instructions advise against including URLs that can change in RFCs that can't. The RFC Editor would likely provide guidance, though.

A revised document is needed to resolve these concerns.

TECHNICAL

This document is very similar to RFC3602 (AES for IPsec).  It leaves out most of section 3, which describes such details as how to select an IV.  Instead, it just cites the "API" in RFC3602.  Pleas remove the "API" reference.  Please include a discussion of IVs.  This document should explicitly explain how ESP is used rather than having a normative reference to RFC 3602.

Please include a packet diagram for the ESP payload.

PROCEDURAL

The header suggests that this is a WG item, but this is an individual submission, not one from the IPsec WG.

Two IANA assignments made (in 4.1 and 4.2), but no IANA considerations section.  One is needed.  For guidance, see: draft-narten-iana-considerations-rfc2434bis-01.txt.

Split normative/informative references.  If possible, you may want to drop the SEED-SMIME reference to avoid unnecessary interdependencies.

EDITORIAL

Two dangling URLs in the text, even though three references include the same URL.  Refer to section 2.8 of draft-rfc-editor-rfc2223bis-08.txt.

Typo in section 1.1:  s/CRYTEC/CRYPTEC/

There are numerous grammar errors.  Please review carefully.

PLEASE CONSIDER

Examples may help with interoperability, but they aren't strictly necessary.