Shared Brotli Compressed Data Format
draft-vandevenne-shared-brotli-format-15

Yes

(Francesca Palombini)
(Murray Kucherawy)

No Objection

Erik Kline
Gunter Van de Velde
Jim Guichard
Paul Wouters
Roman Danyliw
Éric Vyncke
(Zaheduzzaman Sarker)

Note: This ballot was opened for revision 13 and is now closed.

Erik Kline
No Objection
Comment (2024-11-30 for -13) Sent 
# Internet AD comments for draft-vandevenne-shared-brotli-format-13
CC @ekline

* comment syntax:
  - https://github.com/mnot/ietf-comments/blob/main/format.md

* "Handling Ballot Positions":
  - https://ietf.org/about/groups/iesg/statements/handling-ballot-positions/

## Comments

### S8.2, S8.4.3, S9

* It would be good have a reference for "highwayhash" in this document.

## Nits

### S1.1

* "format format" -> "format"

### S4

* "one ore more" -> "one or more"
Gunter Van de Velde
No Objection
Jim Guichard
No Objection
Paul Wouters
No Objection
Roman Danyliw
No Objection
Comment (2024-12-04 for -13) Not sent 
Thank you to Stewart Bryant for the GENART review.
Éric Vyncke
No Objection
Comment (2024-11-28 for -13) Sent 
Thanks for the work done in this document. Just some non-blocking comments.

# Section 1.5.1

s/prefix code 110, prefix code 10/3-bit prefix code b'110, 2-bit prefix code b'10/

Suggest adding a caption for the graphic and referring to it, using the aasvg tool for nicer rendering, and find a way to delineate the 24 bits per grouping.

# Section 8.1

s/bytes 91, 0a, 42, 52/bytes 0x91, 0x0a, 0x42, 0x52/

s/must be 00/must be b'00 and the decoder should/must ???? if not b'00/

# Section 8.2

Add a normative reference to "Highwayhash" (I was about to ballot a DISCUSS on this issue).
Francesca Palombini Former IESG member
Yes
Yes (2024-11-27 for -13) Not sent 
Note to the IESG:

The document is a stand-alone addition to add dictionary support to brotli (RFC 7932) which was also published as Informational, AD sponsored.
The use of the format documented in this doc was discussed in HTTPBIS as part of the work on draft-ietf-httpbis-compression-dictionary (which is in RFC Editor queue), which has a normative reference to this doc.
The document describes a stream format that has been in use by brotli for several years and it was adopted by compression dictionaries as-is.
In addition to the usual IETF LC reviews, two reviews were provided by people with expertise on compression (Yann Collet, creator of LZ4 and zstd, and Felix Handte, on the compression team at Meta). Given the specificity of the document, I evaluate this to be sufficient to publish.
Murray Kucherawy Former IESG member
Yes
Yes (for -13) Not sent 

                            

                        
                    

                
            
        
            
                
            
                
            
                
            
                
            
                
            
                
            
                
                    

                        

                            Zaheduzzaman Sarker Former IESG member
                        

                        

                            
                            No Objection
                            
                        

                    

                    

                        

                            

                                No Objection 
                                
                                    (for -13)
                                
                                
                                    
                                         Not sent