Skip to main content

Last Call Review of draft-ietf-6man-sids-03
review-ietf-6man-sids-03-genart-lc-enghardt-2023-10-26-00

Request Review of draft-ietf-6man-sids
Requested revision No specific revision (document currently at 06)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2023-10-27
Requested 2023-10-13
Authors Suresh Krishnan
I-D last updated 2023-10-26
Completed reviews Dnsdir Telechat review of -05 by Petr Špaček (diff)
Secdir Telechat review of -05 by Linda Dunbar (diff)
Intdir Telechat review of -05 by Juan-Carlos Zúñiga (diff)
Opsdir Last Call review of -03 by Yingzhen Qu (diff)
Secdir Last Call review of -03 by Linda Dunbar (diff)
Genart Last Call review of -03 by Reese Enghardt (diff)
Assignment Reviewer Reese Enghardt
State Completed
Request Last Call review on draft-ietf-6man-sids by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/JV1zm-SyziCtncVBqja0xgRTPl0
Reviewed revision 03 (document currently at 06)
Result Almost ready
Completed 2023-10-26
review-ietf-6man-sids-03-genart-lc-enghardt-2023-10-26-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-6man-sids-03
Reviewer: Reese Enghardt
Review Date: 2023-10-26
IETF LC End Date: 2023-10-27
IESG Telechat date: Not scheduled for a telechat

Summary: The document is almost ready for publication as an Informational RFC,
pending some clarifications in the IANA Considerations and some text tweaks.

Major issues: None.

Minor issues:

Abstract:
The abstract does not mention that the document allocates a Global Unicast
Prefix for SIDs, which seems like a major contribution of this document. I
suggest mentioning this contribution in the abstract.

Section 1:
"SR segment endpoint nodes process a local segment present the Destination
Address of an IPv6 header." I have a hard time parsing this phrase, and I think
adding a preposition or an "-ing" somewhere would make it easier. Is this "SR
segment endpoint nodes processing a local segment present the Destination
Address of an IPv6 header." or "SR segment endpoint nodes process a local
segment which presents the Destination Address of an IPv6 header." or something
else?

Section 3:
Are all SIDs IPv6 addresses? This section sounds like it implies that they are,
while the abstract says that they merely "resemble" IPv6 addresses. I suggest
clarifying this point in the document.

"Such a SID is assigned to a node within a prefix defined as a Locator of
length L." Does "Such a SID" refer to the previous sentence, which talks about
SIDs with L+F+A < 128? If not, what is meant by "Such a SID"?

IANA Considerations:
This document asks IANA to allocate a Global Unicast Prefix for SIDs. According
to Section 5.1 of RFC 5226, I suggest that this document explicitly identify
the namespace in which a value is to be allocated - The "Internet Protocol
Version 6 Address Space" registry has multiple prefixes marked as "Reserved by
IETF". According to RFC 3513, I assume this will be under the 1000::/4 prefix,
but I may be missing context here.

Nits/editorial comments:

Section 3:
"Please note that [BCP198] does not override the rules in [RFC4291], but merely
limits where their impact is observed" Missing full stop at the end.