Last Call Review of draft-ietf-6man-spring-srv6-oam-09
review-ietf-6man-spring-srv6-oam-09-rtgdir-lc-venaas-2021-03-26-00

Request Review of draft-ietf-6man-spring-srv6-oam
Requested revision No specific revision (document currently at 13)
Type Last Call Review
Team Routing Area Directorate (rtgdir)
Deadline 2021-03-22
Requested 2021-03-08
Requested by Alvaro Retana
Authors Zafar Ali , Clarence Filsfils , Satoru Matsushima , Daniel Voyer , Mach Chen
I-D last updated 2021-03-26
Completed reviews Rtgdir Last Call review of -09 by Stig Venaas (diff)
Tsvart Last Call review of -09 by Magnus Westerlund (diff)
Secdir Last Call review of -09 by Dan Harkins (diff)
Genart Last Call review of -09 by Matt Joras (diff)
Opsdir Last Call review of -10 by Dan Romascanu (diff)
Intdir Telechat review of -10 by Carlos J. Bernardos (diff)
Secdir Telechat review of -10 by Dan Harkins (diff)
Assignment Reviewer Stig Venaas
State Completed
Request Last Call review on draft-ietf-6man-spring-srv6-oam by Routing Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/r1z5jAkfoknPl1TtEK9HSBp_O-c
Reviewed revision 09 (document currently at 13)
Result Has issues
Completed 2021-03-26
review-ietf-6man-spring-srv6-oam-09-rtgdir-lc-venaas-2021-03-26-00
Hello,

I have been selected as the Routing Directorate reviewer for this
draft. The Routing Directorate seeks to review all routing or
routing-related drafts as they pass through IETF last call and IESG
review, and sometimes on special request. The purpose of the review is
to provide assistance to the Routing ADs. For more information about
the Routing Directorate, please see
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs,
it would be helpful if you could consider them along with any other
IETF Last Call comments that you receive, and strive to resolve them
through discussion or by updating the draft.

Document: draft-ietf-6man-spring-srv6-oam-09.txt
Reviewer: Stig Venaas
Review Date: 2021-03-26
IETF LC End Date: 2021-03-22
Intended Status: Proposed Standard

Summary:

I have some minor concerns about this document that I think should be
resolved before publication.

Comments:

The document is quite good and easy to read. There are a couple of
minor language issues that I'm sure the RFC editor will take care of.
My only concern is the security considerations.

Major Issues:

No major issues found.

Minor Issues:

The Security considerations need more details.

Aren't there any concerns about attackers sending packets with the
O-flag set? Could packets be sent to the OAM process at a high rate?
As mentioned, packet punting should be rate limited. Could an attacker
cause legitimate probes to be dropped by sending too many illegitimate
probes?

Rate-limiting is a SHOULD. There should be some discussion on the
importance of rate-limiting. Why is it important, and what may be the
reasons for not rate-limiting? Since it isn't a MUST, it appears there
may be cases where it makes sense not to rate-limit.

Nits:
A few minor language issues, but these are very minor and will be
addressed by the RFC editor.
Some references are not up to date.

Regards,
Stig