Last Call Review of draft-ietf-6tisch-msf-10
review-ietf-6tisch-msf-10-genart-lc-gurbani-2020-02-14-00
Request | Review of | draft-ietf-6tisch-msf |
---|---|---|
Requested revision | No specific revision (document currently at 18) | |
Type | Last Call Review | |
Team | General Area Review Team (Gen-ART) (genart) | |
Deadline | 2020-02-27 | |
Requested | 2020-02-13 | |
Authors | Tengfei Chang , Mališa Vučinić , Xavier Vilajosana , Simon Duquennoy , Diego Roberto Dujovne | |
I-D last updated | 2020-02-14 | |
Completed reviews |
Genart Last Call review of -10
by Vijay K. Gurbani
(diff)
Secdir Last Call review of -16 by Donald E. Eastlake 3rd (diff) Genart Telechat review of -11 by Vijay K. Gurbani (diff) |
|
Assignment | Reviewer | Vijay K. Gurbani |
State | Completed | |
Request | Last Call review on draft-ietf-6tisch-msf by General Area Review Team (Gen-ART) Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/gen-art/dbfzo9F7U10YkYBYpaMg9bxyc_U | |
Reviewed revision | 10 (document currently at 18) | |
Result | Almost ready | |
Completed | 2020-02-14 |
review-ietf-6tisch-msf-10-genart-lc-gurbani-2020-02-14-00
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-6tisch-msf-10 Reviewer: Vijay K. Gurbani Review Date: 2020-02-14 IETF LC End Date: 2020-02-27 IESG Telechat date: Not scheduled for a telechat Summary: The draft is almost ready to be published as a Proposed Standard. Major issues: 1 Minor issues: 0 Nits/editorial comments: 1 Sn below stands for "Section n". Major: - S2, paragraph 4: The text says that "...a node implementing MSF SHOULD enforce some rules for limiting the traffic broadcast frames...". It goes ahead and gives an example of the "Trickle" operation, but in the very next sentence, it says, "This behavior is out of the scope for MSF." I am confused since the paragraph does not seem self consistent. The paragraph is asking the implementor to use normative strength (SHOULD) to enforce "some" rules, but does not enumerate the rules. To be fair, the paragraph gives one example of such a rule, but immediately invalidates that example! What would an implementor do? Where would he or she go to get an idea of "some" rules that can be used to limit the traffic of broadcast frames? Perhaps some reference could be provided to a document that contains these rules? Nits: - S6: s/It is calculated/The timeout value is calculated/ Thank you.