Telechat Review of draft-ietf-acme-acme-08
review-ietf-acme-acme-08-tsvart-telechat-stiemerling-2017-11-28-00

Request Review of draft-ietf-acme-acme
Requested rev. no specific revision (document currently at 18)
Type Telechat Review
Team Transport Area Review Team (tsvart)
Deadline 2017-11-28
Requested 2017-11-06
Requested by Mirja Kühlewind
Other Reviews Genart Telechat review of -07 by Dale Worley (diff)
Opsdir Telechat review of -07 by Éric Vyncke (diff)
Genart Last Call review of -11 by Dale Worley (diff)
Genart Telechat review of -12 by Dale Worley (diff)
Secdir Telechat review of -12 by Scott Kelly (diff)
Genart Last Call review of -13 by Dale Worley (diff)
Comments
As this is an important protocol, an additional TSV review would be great! Thanks!
Review State Completed
Reviewer Martin Stiemerling
Review review-ietf-acme-acme-08-tsvart-telechat-stiemerling-2017-11-28
Posted at https://mailarchive.ietf.org/arch/msg/tsv-art/qyt1PXOrSdzDlGaSPbp-p2x8Ivc
Reviewed rev. 08 (document currently at 18)
Review result Ready with Nits
Draft last updated 2017-11-28
Review completed: 2017-11-28

Review
review-ietf-acme-acme-08-tsvart-telechat-stiemerling-2017-11-28

Hi all,

I've reviewed this document as part of the transport area review team's 
ongoing effort to review key IETF documents. These comments were written 
primarily for the transport area directors, but are copied to the 
document's authors for their information and to allow them to address 
any issues raised. When done at the time of IETF Last Call, the authors 
should consider this review together with any other last-call comments 
they receive. Please always CC tsv-art@… if you reply to or forward this 
review.

Summary:
This draft is basically ready for publication, but has nits that should 
be fixed before publication.

Editorials:
- Abstract says "DISCLAIMER:...":
This should be removed before publication or there is an issue with the 
intended status of Standards Track.

- A nit, but: section 7.3.4 uses http instead of https in the example:
"instance": "http://example.com/agreement/?token=W8Ih3PswD-8"
All other instances use https.


Technicals:

- Section 8.2. Retrying challenges
Any guidance on what "some times" means? At least in terms of a time 
scale, e.g., seconds, minutes, hours?


Thanks for the clearly written document!

Regards,

   Martin Stiemerling