Last Call Review of draft-ietf-acme-star-delegation-06
review-ietf-acme-star-delegation-06-genart-lc-krishnan-2021-03-25-00

Request Review of draft-ietf-acme-star-delegation
Requested rev. no specific revision (document currently at 07)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2021-03-22
Requested 2021-03-08
Authors Yaron Sheffer, Diego Lopez, Antonio Pastor, Thomas Fossati
Draft last updated 2021-03-25
Completed reviews Secdir Last Call review of -06 by Russ Housley (diff)
Genart Last Call review of -06 by Suresh Krishnan (diff)
Secdir Telechat review of -07 by Russ Housley
Assignment Reviewer Suresh Krishnan 
State Completed
Review review-ietf-acme-star-delegation-06-genart-lc-krishnan-2021-03-25
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/ucOfjPeTjSdLdunkW066xaqyq1U
Reviewed rev. 06 (document currently at 07)
Review result Ready with Nits
Review completed: 2021-03-25

Review
review-ietf-acme-star-delegation-06-genart-lc-krishnan-2021-03-25

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-acme-star-delegation-??
Reviewer: Suresh Krishnan
Review Date: 2021-03-23
IETF LC End Date: 2021-03-22
IESG Telechat date: Not scheduled for a telechat

Summary:

Major issues:

Minor issues:

Nits/editorial comments:

There are a few lines longer than 72 characters and this will fail the ID Nits check. I dug a bit deeper and found out some of these lines were in the CDDL in Appendix B. Here are the lines if that helps.

% awk 'length($0)>72 { print length($0) $0}' draft-ietf-acme-star-delegation-06.txt 
73Intended status: Standards Track                                D. López
76; RSASSA-PSS with SHA-256, MGF-1 with SHA-256, and a salt length of 32 bytes
76; RSASSA-PSS with SHA-384, MGF-1 with SHA-384, and a salt length of 48 bytes
76; RSASSA-PSS with SHA-512, MGF-1 with SHA-512, and a salt length of 64 bytes