Early Review of draft-ietf-anima-brski-prm-05
review-ietf-anima-brski-prm-05-yangdoctors-early-bjorklund-2022-12-05-00

Request Review of draft-ietf-anima-brski-prm-05
Requested revision 05 (document currently at 15)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2022-12-24
Requested 2022-11-15
Requested by Toerless Eckert
Authors Steffen Fries , Thomas Werner , Eliot Lear , Michael Richardson
I-D last updated 2022-12-05
Completed reviews Secdir Early review of -10 by Charlie Kaufman (diff)
Secdir Early review of -05 by Charlie Kaufman (diff)
Yangdoctors Early review of -05 by Martin Björklund (diff)
Iotdir Early review of -05 by Marco Tiloca (diff)
Iotdir Last Call review of -15 by Marco Tiloca
Comments 
This document is getting close to WGLC, and we would appreciate early review of the three above listed directorates (security, IoT and YANG doctors) as the in our opinion most important ones.

The YANG doctor review is particularily important, because we would want to use this document as the spearhead for resolving our issue of augmenting rfc8366 YANG, and so far, the discussions we have on netmod/anima with YANG experts have not lead to a working suggestion. This problem applies to multiple ANIMA drafts intending to augment rfc8366 YANG, and if the solution is that we first need to fix up the rfc8366 YANG, e.g.: via rfc8366bis or a differently fixed version of its YANG module, then this would become a new dependency for all those doc. The authors of this draft suggested that Jan Lindblad has been helpful on these type of issues in the past already, and he might be more familiar with them than other YANG doctors.

Thank you so much
    Toerless on behalf of ANIMA (chairs).
Assignment Reviewer Martin Björklund
State Completed
Request Early review on draft-ietf-anima-brski-prm by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/JzguDpgCMGArOiFTifNYHbEhf84
Reviewed revision 05 (document currently at 15)
Result Ready w/issues
Completed 2022-12-05
review-ietf-anima-brski-prm-05-yangdoctors-early-bjorklund-2022-12-05-00
This is my YANG doctor's review of draft-ietf-anima-brski-prm-05.

From a YANG perspective, this module is quite simple and looks good.  The only
thing you should change is to use sx:structure (from RFC 8791) instead of
rc:yang-data.

However, you wrote in the request for the review "we would want to use this
document as the spearhead for resolving our issue of augmenting rfc8366 YANG". 
I have read the thread on the netmod mailing list, but I am not sure I
understand the problem correctly.  In the ML thread, there was the example of
two independent modules that augmented RFC8366:

  module B adds some leafs to RFC8366
  module C adds some leafs to RFC8366

If both B and C defines *new* distinct structures, then the approach with
groupings and specific structures in B and C is correct.

But if the intention is to add leafs to the *existing* structure defined in RFC
8366 ("voucher-artifact"), then this approach doesn't work.  If this is the
intention, the base structure needs to be defined with sx:structure, and B and
C would have to use sx:augment-structure to add their leafs.  This approach
would e.g. allow an implementation to instantiate a "voucher-artifact"
structure with leaves from *both* B and C, even though they are independent
modules.

/martin