Skip to main content

Last Call Review of draft-ietf-anima-brski-prm-17
review-ietf-anima-brski-prm-17-genart-lc-kyzivat-2025-01-27-00

Request Review of draft-ietf-anima-brski-prm
Requested revision No specific revision (document currently at 18)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2025-01-30
Requested 2025-01-16
Authors Steffen Fries , Thomas Werner , Eliot Lear , Michael Richardson
I-D last updated 2025-01-27
Completed reviews Secdir Early review of -10 by Charlie Kaufman (diff)
Secdir Early review of -05 by Charlie Kaufman (diff)
Yangdoctors Early review of -05 by Martin Björklund (diff)
Iotdir Early review of -05 by Marco Tiloca (diff)
Iotdir Last Call review of -15 by Marco Tiloca (diff)
Secdir Last Call review of -17 by Wes Hardaker (diff)
Opsdir Last Call review of -15 by Ran Chen (diff)
Dnsdir Last Call review of -17 by David C Lawrence (diff)
Genart Last Call review of -17 by Paul Kyzivat (diff)
Assignment Reviewer Paul Kyzivat
State Completed
Request Last Call review on draft-ietf-anima-brski-prm by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/U9a-O6LoaVGdKKnkBHozb_ezkWY
Reviewed revision 17 (document currently at 18)
Result Ready w/nits
Completed 2025-01-27
review-ietf-anima-brski-prm-17-genart-lc-kyzivat-2025-01-27-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-anima-brski-prm-17
Reviewer: Paul Kyzivat
Review Date: 2025-01-27
IETF LC End Date: 2025-01-30
IESG Telechat date: ?

Summary:

This draft is basically ready for publication, but has nits that should 
be fixed before publication.

This was this reviewer's first introduction to anima. As a result, this 
review is limited to document form, not technical details.

It is a very well written document. It is however forbiddingly long and 
intimidating to read. It has a very distinct repetitive structure. (Many 
twisty little passages, all different, but very similar.) It seems like 
it could perhaps be represented in a more concise way that would be 
easier to read. But I don't have a specific suggestion.

ISSUES: 0
NITS: 3

1) NIT: Non-RFC2606-compliant FQDN

Section 6.1.2 (Discovery of the Pledge) uses an FQDN, 
"_brski-pledge._tcp.local", that triggers an IdNits 
non-RFC2606-compliant FQDN warning. This is perhaps mitigated somewhat 
by being a local FQDN.

I don't have a specific recommendation whether or not to change this.

2) NIT: Language

In the first paragraph of Section 8 (Logging), I suggest minor syntax 
tweaks in the first paragraph:

s/Recommend key events for logging comprise/Recommended key events for 
logging comprise:/

3) NIT: Stale References

There are three outdated references to related anima documents. I trust 
these will be dealt with in due course.