IETF Last Call Review of draft-ietf-asap-sip-auto-peer-30
review-ietf-asap-sip-auto-peer-30-yangdoctors-lc-aries-2025-09-14-00

1 module in this draft:
- ietf-sip-auto-peering@2025-08-10.yang

YANG compiler errors or warnings (pyang 2.7.1, yanglint 3.13.5)
- warning: unexpected latest revision "2025-10-08" in
ietf-sip-auto-peering@2025-08-10.yang, should be "2025-08-10"

General Comments
--------------------
This review is a follow on to previous telechat review and offline consultation
to shape the prior review.

Overall, this module is in much better shape now that prior comments have been
addressed however there are still some lingering items that need to be
addressed (listed above/below).

YANG Module
--------------------
- Revision date is incorrect as referenced by the above compiler error
- L#257: Feel free to remove `mandatory true;` statement as this leaf is a list
  key
- L#265: (Nit) Use consistent spelling for the word Authorization/Authorisation
  (All other references currently use the latter)
- L#827: The description indicates TLS but should the enum variant also include
  the word "tls" as this is just a nested leaf under 'signaling/version' which
  is not descriptive in itself as to TLS.
- L#904: Expand 'cert-delegation' to full word? (and adjust L#927 reference)
- Nit: It appears that line breaks (and some alignment) do not have consistency
  across description statements.  Suggest correcting these for consistency.

Instance Data
--------------------
- Instance data validates correctly