Skip to main content

Last Call Review of draft-ietf-babel-source-specific-06
review-ietf-babel-source-specific-06-secdir-lc-shekh-yusef-2020-10-25-00

Request Review of draft-ietf-babel-source-specific
Requested revision No specific revision (document currently at 08)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-10-27
Requested 2020-10-13
Authors Matthieu Boutier , Juliusz Chroboczek
I-D last updated 2020-10-25
Completed reviews Rtgdir Early review of -01 by Joel M. Halpern (diff)
Rtgdir Last Call review of -06 by He Jia (diff)
Genart Last Call review of -06 by Dan Romascanu (diff)
Opsdir Last Call review of -06 by Dan Romascanu (diff)
Secdir Last Call review of -06 by Rifaat Shekh-Yusef (diff)
Assignment Reviewer Rifaat Shekh-Yusef
State Completed
Request Last Call review on draft-ietf-babel-source-specific by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/OUFL61jw4fu4IjeobVXJgg2i6TI
Reviewed revision 06 (document currently at 08)
Result Has nits
Completed 2020-10-25
review-ietf-babel-source-specific-06-secdir-lc-shekh-yusef-2020-10-25-00
Section 7, Second Paragraph:

  “A node MUST NOT send more that one Source Prefix sub-TLV in a TLV, and a node
   receiving more than one Source Prefix sub-TLV in a single TLV SHOULD
   ignore this TLV.  It MAY ignore the whole packet.”

1. “That” -> “Than”
2. This paragraph implies that a node might accept the TLV with more than one
Source Prefix sub-TLV, but it does not state when a node can do that. You might
want to elaborate on the conditions that a node is allowed to do that.

Otherwise, the security considerations section seems reasonable and addresses
the issues that might arise because of the added flexibility of the source
prefix.

Regards,
 Rifaat