Last Call Review of draft-ietf-babel-yang-model-09
review-ietf-babel-yang-model-09-yangdoctors-lc-krejci-2021-05-01-00
| Request | Review of | draft-ietf-babel-yang-model |
|---|---|---|
| Requested revision | No specific revision (document currently at 13) | |
| Type | Last Call Review | |
| Team | YANG Doctors (yangdoctors) | |
| Deadline | 2021-04-23 | |
| Requested | 2021-04-08 | |
| Requested by | Martin Vigoureux | |
| Authors | Mahesh Jethanandani , Barbara Stark | |
| I-D last updated | 2021-05-01 | |
| Completed reviews |
Yangdoctors Early review of -03
by Radek Krejčí
(diff)
Secdir Last Call review of -09 by Loganaden Velvindron (diff) Yangdoctors Last Call review of -09 by Radek Krejčí (diff) Rtgdir Last Call review of -09 by Ron Bonica (diff) Genart Last Call review of -09 by Stewart Bryant (diff) |
|
| Assignment | Reviewer | Radek Krejčí |
| State | Completed | |
| Request | Last Call review on draft-ietf-babel-yang-model by YANG Doctors Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/yang-doctors/Ako_Ey0QxK9brD2LtlBsFTwVAk8 | |
| Reviewed revision | 09 (document currently at 13) | |
| Result | Ready w/nits | |
| Completed | 2021-05-01 |
review-ietf-babel-yang-model-09-yangdoctors-lc-krejci-2021-05-01-00
This is my YANG doctor review of draft-ietf-babel-yang-model containing ietf-babel@2021-03-12.yang module. The draft and the module are well written and I have just two minor comments: - The copyright year in the YANG module should be probably 2021, not 2020. - Some values of the specific statements (e.g. min-elements) are quoted despite it is not necessary (the value must be a number or a single word). I propose to use pyang/yanglint to generate the module since it also unifies all the formatting and quoting.