Skip to main content

Last Call Review of draft-ietf-bess-ir-03
review-ietf-bess-ir-03-genart-lc-kyzivat-2016-08-09-00

Request Review of draft-ietf-bess-ir
Requested revision No specific revision (document currently at 05)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2016-08-10
Requested 2016-07-28
Authors Eric C. Rosen , Karthik Subramanian , Zhaohui (Jeffrey) Zhang
I-D last updated 2016-08-09
Completed reviews Genart Last Call review of -03 by Paul Kyzivat (diff)
Genart Last Call review of -03 by Paul Kyzivat (diff)
Secdir Last Call review of -03 by Magnus Nyström (diff)
Opsdir Last Call review of -03 by Qin Wu (diff)
Assignment Reviewer Paul Kyzivat
State Completed
Request Last Call review on draft-ietf-bess-ir by General Area Review Team (Gen-ART) Assigned
Reviewed revision 03 (document currently at 05)
Result Ready w/issues
Completed 2016-08-09
review-ietf-bess-ir-03-genart-lc-kyzivat-2016-08-09-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed by the
IESG for the IETF Chair. Please treat these comments just like any other
last call comments. For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-bess-ir-04
Reviewer: Paul Kyzivat
Review Date: 2016-08-09
IETF LC End Date: 2016-08-10
IESG Telechat date: 2016-08-18

Summary:

Unfortunately, I don't have the expertise to review this draft.

(Of the review summaries available to me, the one I want to use is "This
draft has serious issues, described in the review, and needs to be
rethought." But I don't think I am in a position to make such a
judgement given my lack of knowledge of the subject domain.)

Issues:

Major: 0
Minor: 2
Nits:  0

(1) MINOR:

Section 5 begins:

    As previously specified, when the "Tunnel Type" field of a PTA is set
    to "IR", the "Tunnel Identifier" field of that PTA does not contain
    the IR P-tunnel identifier.  This section specifies the procedures
    for setting the "Tunnel Identifier" field of the PTA when the "Tunnel
    Type" field of the PTA is set to "IR".

I have trouble parsing this so it makes sense. The problem is with "As
previously specified". Normally when I see something like this I expect
it to mean "previously within this document". I think in this case it
means in RFCs 6513 and/or 6514. I think this ought to be clearer. E.g.,

    As specified in [RFC6513], ...

(2) MINOR (?!?):

Lacking any knowledge of the subject matter of this draft, I found it
impossible to review in a meaningful way. But I tried!

I came to the tentative conclusion that this document is struggling to
document an extremely complex system. In such a situation publishing the
sort of documentation provided here is probably better than not doing
so. But I fear it isn't sufficient - that it will be unlikely that a new
implementer, schooled in the subject matter, will be able to create a
correct implementation. The problem is with the system/algorithms, not
with the document.

(NOTE: I've made this minor rather than major because I don't consider
myself competent to say this is a real problem or if it is one that this
draft should be expected to fix.)