Last Call Review of draft-ietf-bfd-rfc9127-bis-01
review-ietf-bfd-rfc9127-bis-01-yangdoctors-lc-lindblad-2022-02-03-00
| Request | Review of | draft-ietf-bfd-rfc9127-bis |
|---|---|---|
| Requested revision | No specific revision (document currently at 04) | |
| Type | Last Call Review | |
| Team | YANG Doctors (yangdoctors) | |
| Deadline | 2022-02-03 | |
| Requested | 2022-01-21 | |
| Requested by | John Scudder | |
| Authors | Mahesh Jethanandani , Reshad Rahman , Lianshu Zheng , Santosh Pallagatti , Greg Mirsky | |
| Draft last updated | 2022-02-03 | |
| Completed reviews |
Rtgdir Last Call review of -02
by
Russ White
(diff)
Genart Last Call review of -01 by Joel M. Halpern (diff) Yangdoctors Last Call review of -01 by Jan Lindblad (diff) |
|
| Comments |
The assigned YANG Doctor should make their own decision about what form of review to do of course but here is some background information that may be helpful. rfc9127-bis is a republication of RFC 9127 to fix an error that was found soon after publication. Those changes were discussed with YANG Doctors before submitting rfc9127-bis. As such, my hope is that it may be sufficient for the assigned YANG Doctor to confirm that the changes made are as represented in the YANG Doctors thread(s), and that you won't have to repeat a lot of work. Relevant email threads include: https://mailarchive.ietf.org/arch/msg/yang-doctors/TWhYtbHtIkQd7PV18MNRsy75Y-o/ https://mailarchive.ietf.org/arch/msg/yang-doctors/5HAnuADVBexJ_uTh7aGXncTdh5g/ |
|
| Assignment | Reviewer | Jan Lindblad |
| State | Completed | |
| Review |
review-ietf-bfd-rfc9127-bis-01-yangdoctors-lc-lindblad-2022-02-03
|
|
| Posted at | https://mailarchive.ietf.org/arch/msg/yang-doctors/IJ2Zb1Fsw_0kZMTXwc_u_kTxIAA | |
| Reviewed revision | 01 (document currently at 04) | |
| Result | Ready with Issues | |
| Completed | 2022-02-03 |
review-ietf-bfd-rfc9127-bis-01-yangdoctors-lc-lindblad-2022-02-03-00
This is the last call YANG Doctor review of draft-ietf-bfd-rfc9127-bis. Browsing the mail archives, this has been a long story. Realizing that the context of the bis is to fix a particular issue, I have focused only on the diffs from RFC 9127. I feel any additional nitpicks I might find in a complete review would not be welcome at this stage. I have reviewed the diffs, and find them fulfill the desired technical goals. Since this update breaks backwards compatibility as defined in RFC 6020 sec 10 and RFC 7950 sec 11, the process for approving this change has been discussed at length. One argument that has been put forward for going ahead is that the previous version of this module was released only a short time ago, so there is no proliferation of impacted systems in the field. Another argument has been that the YANG Versioning Design Team is working on updated backwards compatibility rules. The Ver-DT proposed updates to the compatibility rules would indeed allow a change of this kind under certain conditions. A key condition for allowing such a break with the backwards compatibility is that the module revision history announces this break clearly to all readers. This is not the case in the -01 version of the modules. revision 2022-01-04 { description "Updates to add client configuration parameters feature."; In my YANG Doctor opinion, updating the revision statement to clearly state that this version is not backwards compatible with the previous version is an absolute requirement. I think it would also be fair to module readers to add a few sentences explaining what's going on here.