Last Call Review of draft-ietf-bfd-stability-08
review-ietf-bfd-stability-08-yangdoctors-lc-aries-2021-03-21-00
| Request | Review of | draft-ietf-bfd-stability-08 |
|---|---|---|
| Requested revision | 08 (document currently at 12) | |
| Type | Last Call Review | |
| Team | YANG Doctors (yangdoctors) | |
| Deadline | 2021-04-05 | |
| Requested | 2021-03-09 | |
| Requested by | Reshad Rahman | |
| Authors | Ashesh Mishra , Mahesh Jethanandani , Ankur Saxena , Santosh Pallagatti , Mach Chen , Peng Fan | |
| I-D last updated | 2021-03-21 | |
| Completed reviews |
Yangdoctors Last Call review of -08
by Ebben Aries
(diff)
|
|
| Comments |
WGLC discussions has led to addition of counters via augmentation of BFD YANG (in RFC Editor queue and in MISSREF for 900+ days) . The YANG model augment is very small. |
|
| Assignment | Reviewer | Ebben Aries |
| State | Completed | |
| Request | Last Call review on draft-ietf-bfd-stability by YANG Doctors Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/yang-doctors/rsYoOFHgZSLQaEcmdUD8mVgwo40 | |
| Reviewed revision | 08 (document currently at 12) | |
| Result | Ready w/nits | |
| Completed | 2021-03-21 |
review-ietf-bfd-stability-08-yangdoctors-lc-aries-2021-03-21-00
One of the simpler YD reviews since this draft contains only a single module with a single r/o leaf augment to various other BFD module nodes. 1 module in this draft: - ietf-bfd-stability@2021-02-24.yang YANG compiler errors or warnings (pyang 2.4.0, yanglint 1.10.17, confdc 7.2.3.4) - warning: RFC 8407: 3.1: The IETF Trust Copyright statement seems to be missing - Minor issue just due to slight wording adjustment from copyright info normally used in the draft/RFC itself https://trustee.ietf.org/documents/trust-legal-provisions/tlp-5/ Module ietf-bfd-stability@2021-02-24.yang: - Contact information should follow formatting seen in other published modules. Just some minor cleanup/readjustments here. - Various augments will augment the respective 'session-statistics' container however for 'bfd-lag:member-links/micro-bfd-ipv4', 'bfd-lag:member-links/micro-bfd-ipv6' and 'bfd-mpls:sessions' these augments sit in parallel to that container. Is there any reason this is not consistent? General comments on the draft/modules: - Section 7.2: It is stated the document registers "2" YANG modules when it is infact only a single module Overall, just minor nits and view as ready from a YANG doctor review standpoint once the above is addressed