Early Review of draft-ietf-bfd-unsolicited-01
review-ietf-bfd-unsolicited-01-yangdoctors-early-bjorklund-2019-08-19-00

Request Review of draft-ietf-bfd-unsolicited-01
Requested revision 01 (document currently at 16)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2019-09-15
Requested 2019-07-18
Requested by Jeffrey Haas
Authors Enke Chen , Naiming Shen , Robert Raszuk , Reshad Rahman
I-D last updated 2019-08-19
Completed reviews Yangdoctors Early review of -01 by Martin Björklund (diff)
Rtgdir Last Call review of -09 by Henning Rogge (diff)
Tsvart Last Call review of -11 by Magnus Westerlund (diff)
Genart Last Call review of -10 by Dan Romascanu (diff)
Secdir Last Call review of -11 by Derek Atkins (diff)
Comments 
This document defines extensions to the BFD yang module (still pending IETF publication) for the feature modifications as defined in this document.
Assignment Reviewer Martin Björklund
State Completed
Request Early review on draft-ietf-bfd-unsolicited by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/JJrun3fiY-gjy8zk0qiMUBwxLPU
Reviewed revision 01 (document currently at 16)
Result Ready w/nits
Completed 2019-08-19
review-ietf-bfd-unsolicited-01-yangdoctors-early-bjorklund-2019-08-19-00
I have reviewed this document from a YANG model perspective only.

My only comment is actually for a grouping defined in ietf-bfd-type, but used
in this module.  There is a choice "interval-config-type":

  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
       +--rw enable?                           boolean
       +--rw local-multiplier?                 multiplier
       +--rw (interval-config-type)?
          +--:(tx-rx-intervals)
          |  +--rw desired-min-tx-interval?    uint32
          |  +--rw required-min-rx-interval?   uint32
          +--:(single-interval) {single-minimum-interval}?
             +--rw min-interval?               uint32

This choice is not mandatory and doesn't have a default case, so the question
is what happens if no nodes from the choice has been configured?   I would
expect the choice to have a default case (but this then would apply to
ietf-bfd-types, not this document.)