Last Call Review of draft-ietf-cbor-array-tags-07
review-ietf-cbor-array-tags-07-genart-lc-davies-2019-09-06-00
| Request | Review of | draft-ietf-cbor-array-tags |
|---|---|---|
| Requested revision | No specific revision (document currently at 08) | |
| Type | Last Call Review | |
| Team | General Area Review Team (Gen-ART) (genart) | |
| Deadline | 2019-09-05 | |
| Requested | 2019-08-22 | |
| Authors | Carsten Bormann | |
| I-D last updated | 2019-09-06 | |
| Completed reviews |
Secdir Last Call review of -07
by Steve Hanna
(diff)
Genart Last Call review of -07 by Elwyn B. Davies (diff) Opsdir Last Call review of -07 by Linda Dunbar (diff) Iotdir Telechat review of -07 by Henk Birkholz (diff) |
|
| Assignment | Reviewer | Elwyn B. Davies |
| State | Completed | |
| Request | Last Call review on draft-ietf-cbor-array-tags by General Area Review Team (Gen-ART) Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/gen-art/aLkMDq1PALMSxQRiTgVkZAELRZE | |
| Reviewed revision | 07 (document currently at 08) | |
| Result | Ready w/nits | |
| Completed | 2019-09-06 |
review-ietf-cbor-array-tags-07-genart-lc-davies-2019-09-06-00
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-cbor-array-tags-07 Reviewer: Elwyn Davies Review Date: 2019-09-06 IETF LC End Date: 2019-09-05 IESG Telechat date: Not scheduled for a telechat Summary: Ready with a couple of nits. Apologies for slightly late delivery. Major issues: None Minor issues: None Nits/editorial comments: s1, para 2: s/have received/has received/ s1, para 3: s/This also can/This can also/ s1.1, last para: s/whether that/as to whether that/ s2.1, 2nd para after Table 2 (top of page 5): OLD: It can be computed inversely to the previous formula from the length of the byte string in bytes: "bytelength >> (f + ll)". NEW: It can be computed from the length of the byte string comprising the representation of the array by inverting the previous formula: "bytelength >> (f + ll)". ENDS s2.1: The terms endianness, big endian and litle endian are jargon, if pretty well known jargon, but I don't know if they are considered to be adequately well understood to avoid the need for a reference or an explanation of what is meant.