Last Call Review of draft-ietf-ccamp-gmpls-general-constraints-ospf-te-09
review-ietf-ccamp-gmpls-general-constraints-ospf-te-09-genart-lc-krishnan-2015-03-03-00
Request | Review of | draft-ietf-ccamp-gmpls-general-constraints-ospf-te |
---|---|---|
Requested revision | No specific revision (document currently at 10) | |
Type | Last Call Review | |
Team | General Area Review Team (Gen-ART) (genart) | |
Deadline | 2015-02-26 | |
Requested | 2015-02-12 | |
Authors | Fatai Zhang , Young Lee , Jianrui Han , Greg M. Bernstein , Yunbin Xu | |
I-D last updated | 2015-03-03 | |
Completed reviews |
Genart Last Call review of -09
by Suresh Krishnan
(diff)
Secdir Telechat review of -09 by Phillip Hallam-Baker (diff) |
|
Assignment | Reviewer | Suresh Krishnan |
State | Completed | |
Request | Last Call review on draft-ietf-ccamp-gmpls-general-constraints-ospf-te by General Area Review Team (Gen-ART) Assigned | |
Reviewed revision | 09 (document currently at 10) | |
Result | Ready w/issues | |
Completed | 2015-03-03 |
review-ietf-ccamp-gmpls-general-constraints-ospf-te-09-genart-lc-krishnan-2015-03-03-00
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-ietf-ccamp-gmpls-general-constraints-ospf-te-09.txt Reviewer: Suresh Krishnan Review Date: 2015/03/02 IESG Telechat date: 2015/03/05 Summary: This draft is ready for publication as a Proposed Standard, but I do have some comments you may wish to address. Minor: * Section 5 Isn't separating static and dynamic info of the same TE link another method of scaling? (e.g. encoding the Port Label Restrictions sub-TLV into a separate top level link TLV and advertising in a separate LSA) If so, suggest adding a subsection here to describe it. * Security Considerations: I have an uneasy (potentially unjustified) feeling about the lack of any specific security considerations for the Connectivity Matrix sub-TLV. It looks pretty compute intensive to me. Somebody should probably take a look at the DoS possibilities with a multiple complex decomposed Connectivity Matrices. * IANA Considerations: Looking at the IANA registry, the Sub-TLVs do not have the text sub-TLV tag attached to them. Suggest renaming to OLD: TBD1 | Connectivity Matrix sub-TLV | [This.I-D] NEW: TBD1 | Connectivity Matrix | [This.I-D] OLD: TBD2 | Port Label Restrictions sub-TLV | [This.I-D] NEW: TBD2 | Port Label Restrictions | [This.I-D] Thanks Suresh