Last Call Review of draft-ietf-ccamp-mw-yang-09
review-ietf-ccamp-mw-yang-09-genart-lc-dupont-2018-10-02-00

Request Review of draft-ietf-ccamp-mw-yang
Requested rev. no specific revision (document currently at 13)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2018-10-02
Requested 2018-09-18
Other Reviews Yangdoctors Last Call review of -05 by Jan Lindblad (diff)
Secdir Last Call review of -09 by Russ Housley (diff)
Opsdir Last Call review of -09 by Scott Bradner (diff)
Review State Completed
Reviewer Francis Dupont
Review review-ietf-ccamp-mw-yang-09-genart-lc-dupont-2018-10-02
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/yMAN-qeHqDEeBbfsjfQnYATOd5Y
Reviewed rev. 09 (document currently at 13)
Review result Ready
Draft last updated 2018-10-02
Review completed: 2018-10-02

Review
review-ietf-ccamp-mw-yang-09-genart-lc-dupont-2018-10-02

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ccamp-mw-yang-09.txt
Reviewer: Francis Dupont
Review Date: 20180926
IETF LC End Date: 20181002
IESG Telechat date: unknown

Summary: Ready

Major issues: None

Minor issues: None

Nits/editorial comments: 
 The yang model mixes config, state and actions, not like the others
I know. But if the Yang experts have no concern I have none too...

 - 4 page 7: I notices the date of the model is 2018-06-30 when
  it was modified the 2018-08-31. I don't know the rule, perhaps
  the date is updated just before publication? Not an issue by itself.

 - action manual-switch-working page 30 and many others: please add a
  space before '{'.

 - A.1 page 46: the JSON is not valid (even it is readable) and I am afraid
  it is really JSON and not something JSON like. In detail:
   // does not begin comments in JSON (there are no comments in fact
   in JSON so IMHO it is not a real problem :-)
   extra commas (more an issue)

 - A.1 page 46: please add a space in "single":{

 - same comments about A.2 pages 47 and 48, and A.3 pages 48-50
  (with BTW two "single":{)

 - B page 50: Spain (ESP) -> Spain

Regards

Francis.Dupont@fdupont.fr