Last Call Review of draft-ietf-core-senml-13
review-ietf-core-senml-13-genart-lc-even-2018-03-27-00
Request | Review of | draft-ietf-core-senml |
---|---|---|
Requested revision | No specific revision (document currently at 16) | |
Type | Last Call Review | |
Team | General Area Review Team (Gen-ART) (genart) | |
Deadline | 2018-03-30 | |
Requested | 2018-03-02 | |
Authors | Cullen Fluffy Jennings , Zach Shelby , Jari Arkko , Ari Keränen , Carsten Bormann | |
I-D last updated | 2018-03-27 | |
Completed reviews |
Genart Last Call review of -13
by Roni Even
(diff)
Genart Telechat review of -14 by Roni Even (diff) |
|
Assignment | Reviewer | Roni Even |
State | Completed | |
Request | Last Call review on draft-ietf-core-senml by General Area Review Team (Gen-ART) Assigned | |
Reviewed revision | 13 (document currently at 16) | |
Result | Ready w/nits | |
Completed | 2018-03-27 |
review-ietf-core-senml-13-genart-lc-even-2018-03-27-00
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-core-senml-?? Reviewer: Roni Even Review Date: 2018-03-27 IETF LC End Date: 2018-03-30 IESG Telechat date: 2018-04-19 Summary: The document is ready for publication as a standard track RFC with nits Major issues: Minor issues: Nits/editorial comments: 1. in section 5.1.6 "another devices" should be "other devices" or "another device" 2. in section 8 "It can simply hard code the output replacing the 1-wire device ID starting at byte 0x20 and going to byte 0x2F with it's device ID". I think that the offset ix 0x10 to 0x1f