Last Call Review of draft-ietf-core-sid-15
review-ietf-core-sid-15-genart-lc-dunbar-2021-03-16-00

Request Review of draft-ietf-core-sid
Requested revision No specific revision (document currently at 24)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2021-03-17
Requested 2021-02-24
Authors Michel Veillette , Alexander Pelov , Ivaylo Petrov , Carsten Bormann , Michael Richardson
I-D last updated 2021-03-16
Completed reviews Dnsdir Last Call review of -21 by R. (Miek) Gieben (diff)
Intdir Telechat review of -21 by Brian Haberman (diff)
Iotdir Telechat review of -21 by Stephen Farrell (diff)
Yangdoctors Last Call review of -15 by Xufeng Liu (diff)
Genart Last Call review of -15 by Linda Dunbar (diff)
Assignment Reviewer Linda Dunbar
State Completed
Request Last Call review on draft-ietf-core-sid by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/8dB4NrBDoGCKILyz2wvtvT6sqC0
Reviewed revision 15 (document currently at 24)
Result Not ready
Completed 2021-03-16
review-ietf-core-sid-15-genart-lc-dunbar-2021-03-16-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-core-sid-15
Reviewer: Linda Dunbar
Review Date: 2021-03-16
IETF LC End Date: 2021-03-17
IESG Telechat date: Not scheduled for a telechat

Summary:
This document introduces the globally unique 63-bits integers to identify YANG
items which include data nodes, RPCs, their associated inputs/outputs,
notifications, YANG modules, submodules, and features.

Major issues:
- One of the benefits of YANG is its explicit naming and human-understandable
notations. It will be a nightmare if all the YANG items are represented by
integers. YANG items being represented by integers will be worse than the TYPE
values in the TLVs. At least, the TLV types are in the context of the protocols
and their messages. - It will be a tremendous amount of work to map all YANG
items to globally unique integers. - YANG has been widely deployed without the
numbering system. Which environment will need the integer representations? Who
will validate the numbers used? How to validate the YANG modules represented by
those "integers"?

- SID can be mistaken as Segment Identifiers (SID). Suggest using a different
name.

Minor issues:

Nits/editorial comments:

Best Regards,
Linda Dunbar