Last Call Review of draft-ietf-curdle-ssh-ed25519-ed448-07
review-ietf-curdle-ssh-ed25519-ed448-07-secdir-lc-meadows-2018-12-28-00
Request | Review of | draft-ietf-curdle-ssh-ed25519-ed448 |
---|---|---|
Requested revision | No specific revision (document currently at 11) | |
Type | Last Call Review | |
Team | Security Area Directorate (secdir) | |
Deadline | 2019-01-04 | |
Requested | 2018-12-21 | |
Authors | Ben Harris , Loganaden Velvindron | |
I-D last updated | 2018-12-28 | |
Completed reviews |
Opsdir Last Call review of -07
by Sheng Jiang
(diff)
Secdir Last Call review of -07 by Catherine Meadows (diff) Genart Last Call review of -07 by Linda Dunbar (diff) Genart Telechat review of -09 by Linda Dunbar (diff) |
|
Assignment | Reviewer | Catherine Meadows |
State | Completed | |
Request | Last Call review on draft-ietf-curdle-ssh-ed25519-ed448 by Security Area Directorate Assigned | |
Reviewed revision | 07 (document currently at 11) | |
Result | Has nits | |
Completed | 2018-12-28 |
review-ietf-curdle-ssh-ed25519-ed448-07-secdir-lc-meadows-2018-12-28-00
This draft specifies the use of the digital signature algorithms Ed25519 and Ed448 in the SSH protocol. Most of this, except for syntactic features such as formats and names, can be found in other RFC’s, and the appropriate references are given. The Security Considerations are also given by reference to RFC4241 (security considerations for SSH) and RFC8032 and RFC7479 (for Ed25519 and Ed448). These security considerations sections are very thorough and I don’t see any need for any additions. A nit: The paragraph This document describes the method implemented by OpenSSH and others, and formalizes its use of the name "ssh-ed25519". Additionally, it also describes the use of Ed448 and formalizes its use of the name "ssh-ed448". Would be clearer as This document describes the Ed25519 method implemented by OpenSSH and others, and formalizes its use of the name "ssh-ed25519". Additionally, it also describes the use of Ed448 and formalizes its use of the name "ssh-ed448”.