Last Call Review of draft-ietf-curdle-ssh-modp-dh-sha2-07
review-ietf-curdle-ssh-modp-dh-sha2-07-opsdir-lc-dunbar-2017-08-22-00

Request Review of draft-ietf-curdle-ssh-modp-dh-sha2
Requested rev. no specific revision (document currently at 09)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2017-07-30
Requested 2017-07-16
Other Reviews Genart Last Call review of -07 by Orit Levin (diff)
Secdir Last Call review of -07 by Donald Eastlake (diff)
Review State Completed
Reviewer Linda Dunbar
Review review-ietf-curdle-ssh-modp-dh-sha2-07-opsdir-lc-dunbar-2017-08-22
Posted at https://www.ietf.org/mail-archive/web/ops-dir/current/msg02775.html
Reviewed rev. 07 (document currently at 09)
Review result Has Issues
Draft last updated 2017-08-22
Review closed: 2017-08-22

Review
review-ietf-curdle-ssh-modp-dh-sha2-07-opsdir-lc-dunbar-2017-08-22

I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the operational area directors.

Document editors and WG chairs should treat these comments just like any other last call comments.

 

Document: draft-ietf-curdle-ssh-modp-dh-sha2-07

 

Reviewer: Linda Dunbar

 

Review result: Has issues.

 

Comments:

-        Page 4: Is Figure 1 intended to be empty? Or Figure 1 is to list the names? Why not simply use bullets to list those names? (Instead of Figure)?

-        This document is supposed to “augment the Key Exchange Method Names in RFC4253”. Other than the names, is there anything more? Is the following sentence the main descriptions of those augmentation?

“The group15 through group18 names are the same as those specified in

[RFC3526] 3072-bit MODP Group 15, 4096-bit MODP Group 16, 6144-bit

MODP Group 17, and 8192-bit MODP Group 18.”

 

Thanks, Linda Dunbar

 

Huawei USA IP Technology Lab

5340 Legacy Drive,

Plano, TX 75024

Tel: +1 469-277 - 5840

Fax: +1 469 -277 - 5900