Telechat Review of draft-ietf-detnet-mpls-over-tsn-05
review-ietf-detnet-mpls-over-tsn-05-intdir-telechat-chown-2021-02-14-00

Request Review of draft-ietf-detnet-mpls-over-tsn
Requested revision No specific revision (document currently at 07)
Type Telechat Review
Team Internet Area Directorate (intdir)
Deadline 2021-02-14
Requested 2021-02-08
Requested by Éric Vyncke
Authors Balazs Varga , János Farkas , Andrew G. Malis , Stewart Bryant
I-D last updated 2021-02-14
Completed reviews Rtgdir Last Call review of -05 by Loa Andersson (diff)
Secdir Last Call review of -05 by Yoav Nir (diff)
Opsdir Last Call review of -05 by Jürgen Schönwälder (diff)
Tsvart Last Call review of -05 by Kyle Rose (diff)
Genart Last Call review of -05 by Ines Robles (diff)
Intdir Telechat review of -05 by Tim Chown (diff)
Comments 
Sorry for the short-term request (but this document has been placed very recently on the IESG telechat) but it is about 10 pages long.
It is part of a pair of Time Sensitive Networking documents, a common reviewer would probably be more efficient:

1) draft-ietf-detnet-ip-over-tsn

2) draft-ietf-detnet-mpls-over-tsn

Thank you

-éric
Assignment Reviewer Tim Chown
State Completed
Request Telechat review on draft-ietf-detnet-mpls-over-tsn by Internet Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/int-dir/eRolN1pL4WRRppMoqnNEkSP4aLo
Reviewed revision 05 (document currently at 07)
Result Ready w/nits
Completed 2021-02-14
review-ietf-detnet-mpls-over-tsn-05-intdir-telechat-chown-2021-02-14-00
Hi,

Re: INT-DIR review of draft-ietf-detnet-mpls-over-tsn-06

This draft details how a DetNet MPLS data plane can run over a TSN sub-network.

I have reviewed this document and believe it is Ready for publication, with
Nits, as listed below.

Nits:

p.2
Loss rates -> loss rate
Provides congestion -> provide congestion
For MPLS-based -> for an MPLS-based

p.3
Include MSRP and RSVP-TE?

p.4
And resources -> and resource

p.5
From MPLS -> from the MPLS
Does not -> do not
In case of -> In the case of

As per the IP doc, not being familiar with DetNet in detail it might be useful
to expand on the rationale for mapping to multicast given the “directed” flow.

p.7
As per the IP doc, I note it says there are no requirements stated for
TSN-unaware MPLS DetNet nodes in the document, but is it worth adding something
about requirements to ensure the TSN Relay can be reached?

p.8
Implementations -> implementation

P.9
of the document -> of this document
challanges -> challenges
Are member -=> are members
Single hop -> a single hop
In some case -> in some cases

P.10
Regarding the more complicated triggering for TSN-unaware nodes, should further
text be added about this?

--
Tim