Skip to main content

Last Call Review of draft-ietf-detnet-mpls-over-tsn-05
review-ietf-detnet-mpls-over-tsn-05-opsdir-lc-schoenwaelder-2021-01-26-00

Request Review of draft-ietf-detnet-mpls-over-tsn
Requested revision No specific revision (document currently at 07)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2021-02-05
Requested 2021-01-22
Authors Balazs Varga , János Farkas , Andrew G. Malis , Stewart Bryant
I-D last updated 2021-01-26
Completed reviews Rtgdir Last Call review of -05 by Loa Andersson (diff)
Secdir Last Call review of -05 by Yoav Nir (diff)
Opsdir Last Call review of -05 by Jürgen Schönwälder (diff)
Tsvart Last Call review of -05 by Kyle Rose (diff)
Genart Last Call review of -05 by Ines Robles (diff)
Intdir Telechat review of -05 by Tim Chown (diff)
Assignment Reviewer Jürgen Schönwälder
State Completed
Request Last Call review on draft-ietf-detnet-mpls-over-tsn by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/NwlIK1nZxtGXQFxWQYbbwT2OWaw
Reviewed revision 05 (document currently at 07)
Result Has nits
Completed 2021-01-26
review-ietf-detnet-mpls-over-tsn-05-opsdir-lc-schoenwaelder-2021-01-26-00
This is an informational document that claims to not state any new
requirements or recommendations. I am not following the DetNet work
and I only have a coarse understanding of MPLS. As such, I am not able
to comment on technical details.

There are quite a few sentences that use lowercase 'must' referring to
[IEEE8021CB] and [IEEEP8021CBdb]. These references are informational,
it seems that [1] suggests that more references should be moved to the
normative references section.

Since the document claims to not define requirements, I am wondering
whether all the "must" statements can be found in other documents. For
example:

   A TSN-aware MPLS (DetNet) node implementations must support the
   Sequencing function and the Sequence encode/decode function as
   defined in Clause 7.4 and 7.6 of IEEE 802.1CB [IEEE8021CB] if FRER is
   used inside the TSN sub-network.

In which document do I find this must requirement? I think there
should be references to those documents and the specific sections so
that it is clear where these "must"s are originating from. (Or the
initial promise that this document states not requirements is not
quite correct.)

[1] https://www.ietf.org/about/groups/iesg/statements/normative-informative-references/

Editorial nits:

s/flows with a low/flows with low/

s/provides congestion/provide congestion/

There are some grammar issues throughout the document, I guess the RFC
editor will deal with them.