Skip to main content

Last Call Review of draft-ietf-dhc-dhcpv6-unknown-msg-05
review-ietf-dhc-dhcpv6-unknown-msg-05-genart-lc-krishnan-2014-02-18-00

Request Review of draft-ietf-dhc-dhcpv6-unknown-msg
Requested revision No specific revision (document currently at 08)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2014-02-18
Requested 2014-02-06
Authors Yong Cui , Qi Sun , Ted Lemon
I-D last updated 2014-02-18
Completed reviews Genart Last Call review of -05 by Suresh Krishnan (diff)
Genart Telechat review of -06 by Suresh Krishnan (diff)
Secdir Last Call review of -05 by Chris M. Lonvick (diff)
Opsdir Telechat review of -05 by Carlos Pignataro (diff)
Assignment Reviewer Suresh Krishnan
State Completed
Request Last Call review on draft-ietf-dhc-dhcpv6-unknown-msg by General Area Review Team (Gen-ART) Assigned
Reviewed revision 05 (document currently at 08)
Result Almost ready
Completed 2014-02-18
review-ietf-dhc-dhcpv6-unknown-msg-05-genart-lc-krishnan-2014-02-18-00
I have been selected as the General Area Review Team (Gen-ART) reviewer
for this draft (for background on Gen-ART, please see


http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html

).

Please wait for direction from your document shepherd or AD before
posting a new version of the draft.

Document: draft-ietf-dhc-dhcpv6-unknown-msg-06.txt
Reviewer: Suresh Krishnan
Review Date: 2014/03/25
IESG Telechat date: 2014/03/27



Summary: This draft is almost ready for publication as a Proposed 


Standard but I do have a few comments that the authors may wish to consider.




* Section 4.1 (b)

The following text is unclear.



"if the relay agent receives the message for which it is not the target 


according to the message type."






The text that follows talks about new server-to-relay messages sent to 


the relay agent being forwarded back to the server. Such a message will 


not meet either of the conditions laid out in Section 4.1.




The following text seems extraneous

"  However, this is not strictly necessary, since DHCP does not provide
   a signaling message for rejecting unexpected message types, and
   therefore DHCP servers are not expected to respond to such messages."



What exactly is "this" referring to? The DHCP server is not responding 


anyway to such messages.




* Section 4.2



The prescribed behavior here is contradicts the text in section 4.1 


defining a valid message. Specifically, what happens when a relay 


receives an unknown message type for which it is the intended target. 


According to 4.1, the relay does nothing. According to 4.2 the relay 


forwards.




Thanks
Suresh