Skip to main content

IETF Last Call Review of draft-ietf-dispatch-mime-protobuf-03
review-ietf-dispatch-mime-protobuf-03-artart-lc-miller-2025-10-05-00

Request Review of draft-ietf-dispatch-mime-protobuf
Requested revision No specific revision (document currently at 07)
Type IETF Last Call Review
Team ART Area Review Team (artart)
Deadline 2025-10-07
Requested 2025-09-23
Authors Murray Kucherawy , Warren Kumari , Rob Sloan
I-D last updated 2025-12-03 (Latest revision 2025-12-01)
Completed reviews Genart IETF Last Call review of -03 by Stewart Bryant (diff)
Artart IETF Last Call review of -03 by Darrel Miller (diff)
Artart Telechat review of -04 by Darrel Miller (diff)
Assignment Reviewer Darrel Miller
State Completed
Request IETF Last Call review on draft-ietf-dispatch-mime-protobuf by ART Area Review Team Assigned
Posted at https://mailarchive.ietf.org/arch/msg/art/j83m3DJGh7IIiw5Dj9EUc2HLagE
Reviewed revision 03 (document currently at 07)
Result Ready w/issues
Completed 2025-10-05
review-ietf-dispatch-mime-protobuf-03-artart-lc-miller-2025-10-05-00
This is an ART area review of
https://www.ietf.org/archive/id/draft-ietf-dispatch-mime-protobuf-03.html

## Issues:

### Section 4. Encoding Considerations

> For binary forms that need to transit non-binary transports, a base64
Content-Transfer-Encoding (xref to [RFC4648]) is recommended.

I worry that this statement might lead people to think they should use this as
a header in HTTP, when RFC7231 says it should not be
https://www.rfc-editor.org/rfc/rfc7231#appendix-A.5.

Perhaps simply saying the following would be safer:

> For binary forms that need to transit non-binary transports, a base64
encoding (xref to [RFC4648]) is recommended.

### 7.1. Registration

> Protobuf implementations should accept all versions of wire encodings defined
at the time of implementation.

Is it appropriate to state this requirement in a media type registration?
Should this not be content of the protobuf specification instead?

## Nits:

### 6. Security Considerations

> While it is common for a protobuf definition to be used as input to a code
generator which then produces something executable, but that applies to the
schema language, not serializations.

There is something grammatically off with the "While ..., but" part of this
sentence. I think the "but" can be removed.

In general this doc looks good to me.

Darrel