Last Call Review of draft-ietf-dtn-bpsec-13
|Requested rev.||no specific revision (document currently at 22)|
|Type||Last Call Review|
|Team||Security Area Directorate (secdir)|
|Requested by||Magnus Westerlund|
|Authors||Edward Birrane, Kenneth McKeever|
|Draft last updated||2020-01-09|
Secdir Early review of -06 by Dan Harkins
Genart Last Call review of -12 by Tim Evens (diff)
Secdir Last Call review of -13 by Dan Harkins (diff)
As the Early review indicated that the previous -06 version had issues, I would appreciate a re-review of the latest version. The document has passed IETF last call, but it will not be progressed to IESG for at least two weeks due to the main specification is currently going through IETF last call.
|Reviewed rev.||13 (document currently at 22)|
|Review result||Has Nits|
Hello, 1000 pardons for the tardiness of this re-review. It fell through the cracks and I was reminded of it during the end-of-the-year break. This draft is Ready With (a single) Nit. This draft is much improved over -06 which I previously reviewed. All of my recommendations have been acted on (thank you). The addition of AEAD for the BCB is a very good addition. The block interactions in 3.9 look correct and my only suggestion would be to remove "NOTE:" from the final paragraph which implies it is informative. Also remove "probably" because it is most decidedly insecure. Make this a normative paragraph prohibiting an insecure construction. The examples are helpful, especially as one expands on the other, that helps illustrate the 3.9 block interaction rules. regards, Dan.