Skip to main content

Last Call Review of draft-ietf-ecrit-similar-location-17
review-ietf-ecrit-similar-location-17-artart-lc-allocchio-2022-02-06-00

Request Review of draft-ietf-ecrit-similar-location
Requested revision No specific revision (document currently at 19)
Type Last Call Review
Team ART Area Review Team (artart)
Deadline 2022-02-09
Requested 2022-01-26
Authors Brian Rosen , Roger Marshall , Jeff Martin
I-D last updated 2022-02-06
Completed reviews Genart Last Call review of -17 by Russ Housley (diff)
Secdir Last Call review of -17 by Scott G. Kelly (diff)
Artart Last Call review of -17 by Claudio Allocchio (diff)
Intdir Telechat review of -18 by Tatuya Jinmei (diff)
Assignment Reviewer Claudio Allocchio
State Completed
Request Last Call review on draft-ietf-ecrit-similar-location by ART Area Review Team Assigned
Posted at https://mailarchive.ietf.org/arch/msg/art/gTqJGjkpYHmcYZPoX1oTvPqC_Zg
Reviewed revision 17 (document currently at 19)
Result Ready w/issues
Completed 2022-02-06
review-ietf-ecrit-similar-location-17-artart-lc-allocchio-2022-02-06-00
The document does not have major issues, so it can be considered "ready".
However the way the document is written is often very narrative, instead of
preferring schemas, diagrams etc. and this can sometimes confuse the
implementer while reading it. Here are my suggestions for improvement:

- the abstract can be shortened just to specify directly why we need this
extension - there are in section 3 cases where the sentence id a double
negative (a MUST NOT followed by a negative sentence). They are correct, but
may I suggest to turn them into a single positive (a MUST and a positive
sentence to follow) ? - a "query", "response" etc flow schema may help in
making sections 3 less narrative and more easy to read - all examples are just
"US centric" (e.g. using US style postal addresses): I would suggest
considering also examples take from other different postal addresses schema,
both to show how they fit into the schema itself - there are some typos/nits to
fix with a proof reading

all the best