Telechat Review of draft-ietf-ecrit-similar-location-18
review-ietf-ecrit-similar-location-18-intdir-telechat-jinmei-2022-02-25-00
Request | Review of | draft-ietf-ecrit-similar-location |
---|---|---|
Requested revision | No specific revision (document currently at 19) | |
Type | Telechat Review | |
Team | Internet Area Directorate (intdir) | |
Deadline | 2022-02-27 | |
Requested | 2022-02-20 | |
Requested by | Éric Vyncke | |
Authors | Brian Rosen , Roger Marshall , Jeff Martin | |
I-D last updated | 2022-02-25 | |
Completed reviews |
Genart Last Call review of -17
by Russ Housley
(diff)
Secdir Last Call review of -17 by Scott G. Kelly (diff) Artart Last Call review of -17 by Claudio Allocchio (diff) Intdir Telechat review of -18 by Tatuya Jinmei (diff) |
|
Assignment | Reviewer | Tatuya Jinmei |
State | Completed | |
Request | Telechat review on draft-ietf-ecrit-similar-location by Internet Area Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/int-dir/cRSAyIclT-V3Rb6wUUcAO8VHL7s | |
Reviewed revision | 18 (document currently at 19) | |
Result | Ready | |
Completed | 2022-02-25 |
review-ietf-ecrit-similar-location-18-intdir-telechat-jinmei-2022-02-25-00
I am an assigned INT directorate reviewer for <draft-ietf-ecrit-similar-location-18.txt>. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/ <https://datatracker.ietf.org/group/intdir/about/>. This draft defines a few optional extensions to the LoST protocol as defined in RFC5222 so that the server can provide supplemental information that may be useful for the client. I'm not familiar with the LoST protocol, so it's quite possible my review miss something. With noting that, the draft is very well written, its purpose and explanations are clear, and I didn't find any obvious problem, especially those related to the INT area. I think it's ready for publication. I have a couple of comments, making mostly just out of curiosity. I'd be happy to get clarifications on these points, but these are not blocking issues at all. - The definition of similarity (in Section 2) looks loose to me: Similar Location: A suggested civic location that is similar to an Invalid Location which was used in a LoST query, but which has one or more elements added, modified, or removed such that the suggested location is a Valid Location. If we apply this definition literally, a completely "different" location could be considered to be "similar" as long as it's valid, since all editorial operations can be applied for arbitrary times, right? Perhaps it's intentionally kept loose and left to the server implementation and discretion, but it would be also nice if it gives some example of what would NOT be considered to be similar (for example, what if an element contains a misspelling and fixing it would make it valid?). - Also related to the above definition, can "Similar Location" be used only when the input is invalid? For example, what if both "6000 15th Avenue Northwest" and "6000 15th Avenue Southwest" exist and the input is either of them in a complete form, can we include the other as a "Similar Location"?