Last Call Review of draft-ietf-emu-eap-session-id-03
review-ietf-emu-eap-session-id-03-secdir-lc-vucinic-2020-05-26-00

Request Review of draft-ietf-emu-eap-session-id
Requested rev. no specific revision (document currently at 07)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-05-27
Requested 2020-05-13
Authors Alan DeKok
Draft last updated 2020-05-26
Completed reviews Secdir Last Call review of -03 by Mališa Vučinić (diff)
Genart Last Call review of -04 by Peter Yee (diff)
Opsdir Last Call review of -03 by Menachem Dodge (diff)
Assignment Reviewer Mališa Vučinić 
State Completed
Review review-ietf-emu-eap-session-id-03-secdir-lc-vucinic-2020-05-26
Posted at https://mailarchive.ietf.org/arch/msg/secdir/HByohPKzKEq9nCIunUXoM463KrE
Reviewed rev. 03 (document currently at 07)
Review result Has Nits
Review completed: 2020-05-26

Review
review-ietf-emu-eap-session-id-03-secdir-lc-vucinic-2020-05-26

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments.

The document updates RFC5247 to specify EAP Session-ID definition in case fast re-authentication is used with EAP-AKA and EAP-SIM. The Session-ID definition is based on a server-generated nonce and a MAC. The document also specifies the Session-ID definition for the PEAP method, following the definition of EAP-TLS.

The document is clear and well written. Security considerations section is clear and states no known security issues in the definitions used. A reference to PEAP is missing.

Nits:
Section 3: s/to not modify/do not modify