Last Call Review of draft-ietf-git-github-wg-configuration-06
review-ietf-git-github-wg-configuration-06-secdir-lc-cam-winget-2020-02-28-00
| Request | Review of | draft-ietf-git-github-wg-configuration |
|---|---|---|
| Requested revision | No specific revision (document currently at 07) | |
| Type | Last Call Review | |
| Team | Security Area Directorate (secdir) | |
| Deadline | 2020-02-28 | |
| Requested | 2020-02-14 | |
| Authors | Alissa Cooper , Paul E. Hoffman | |
| I-D last updated | 2020-02-28 | |
| Completed reviews |
Secdir Last Call review of -06
by Nancy Cam-Winget
(diff)
|
|
| Assignment | Reviewer | Nancy Cam-Winget |
| State | Completed | |
| Request | Last Call review on draft-ietf-git-github-wg-configuration by Security Area Directorate Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/secdir/IFaUhoeL7yBRmJa8AU2ywwt74Iw | |
| Reviewed revision | 06 (document currently at 07) | |
| Result | Ready | |
| Completed | 2020-02-28 |
review-ietf-git-github-wg-configuration-06-secdir-lc-cam-winget-2020-02-28-00
SECDIR review of draft-ietf-git-github-wg-configuration-06 Reviewer: Nancy Cam-Winget Review result: Ready with a minor nit and question I have been tracking and actually using the guidelines and tools laid out in this document; as such, it is well written and easy to follow (thank you!). My nits/question are minor: Section 1: - Subjectively, I think the last clause in the last sentence of the 2nd paragraph is superfluous “…using GitHub in a uniform way if desired”. Could be abbreviated to “…using GitHub in a uniform way.” May be sufficient Section 5: There are actually no procedures for the pull requests; admittedly, I don’t know about GitHub’s protective measures….but as I believe anyone can generate a pull request, couldn’t this be an issue from a flood and legitimacy perspective?