Telechat Review of draft-ietf-homenet-dncp-09
review-ietf-homenet-dncp-09-opsdir-telechat-kuarsingh-2015-09-17-00

Request Review of draft-ietf-homenet-dncp
Requested rev. no specific revision (document currently at 12)
Type Telechat Review
Team Ops Directorate (opsdir)
Deadline 2015-09-29
Requested 2015-08-23
Draft last updated 2015-09-17
Completed reviews Genart Last Call review of -07 by Meral Shirazipour (diff)
Genart Telechat review of -09 by Meral Shirazipour (diff)
Genart Telechat review of -10 by Meral Shirazipour (diff)
Genart Telechat review of -11 by Meral Shirazipour (diff)
Opsdir Last Call review of -07 by Victor Kuarsingh (diff)
Opsdir Telechat review of -09 by Victor Kuarsingh (diff)
Rtgdir Early review of -03 by Les Ginsberg (diff)
Rtgdir Early review of -05 by Thomas Clausen (diff)
Rtgdir Early review of -03 by Lizhong Jin (diff)
Assignment Reviewer Victor Kuarsingh
State Completed
Review review-ietf-homenet-dncp-09-opsdir-telechat-kuarsingh-2015-09-17
Reviewed rev. 09 (document currently at 12)
Review result Has Nits
Review completed: 2015-09-17

Review
review-ietf-homenet-dncp-09-opsdir-telechat-kuarsingh-2015-09-17

  
  
    Deal Authors, (resend - error on previous email)





    I have reviewed this document as part of the Operational
    directorate's ongoing effort to review all IETF documents being
    processed by the IESG.  These comments were written with the intent
    of improving the operational aspects of the IETF drafts. Comments
    that are not addressed in last call may be included in AD reviews
    during the IESG review.  Document editors and WG chairs should treat
    these comments just like any other last call comments.





    Document Reviewed -
    
    draft-ietf-homenet-dncp-09


    Link to Document - 

https://tools.ietf.org/html/draft-ietf-homenet-dncp-09





    This document describes the Distributed Node Consensus Protocol
    (DNCP).  AS noted in the abstract, DNCP is a generic state
    synchronization protocol that would be combined with a specific DNCP
    profile to be implemented (along with Trickle and hash trees). 
    Although generic in nature, the first known profile for DNCP is HNCP
    (Home Networking Control Protocol) which was previously review by
    the OPS-DIR.





    This document is on the Standards Track.





    This document is well written and had gone through previous review
    based on quality of text.  No specific textual issues were found
    during my review.  There were a couple of minor items found which
    the authors can comment on, which includes one suggested rewording
    (none seen as blockers).  The section by section review is found
    below.





    Since DNCP is not directly implementation (as it requires a specific
    profile), there are no major perceive operational specific issues
    found with how this specification is written.  Since gaps/open items
    can be address in a specific profile - like HNCP.  The document, as
    presented appears to be operational sound based this review.








    IESG Comments:


    By the time of this review, three ADs have already noted discuss
    points which will not be repeated in this review.  Found here
    (

https://datatracker.ietf.org/doc/draft-ietf-homenet-dncp/ballot/

)





    Found In Nits:





(

https://tools.ietf.org/idnits?url="">)


    - Use of lower case not with SHOULD statement (see Paragraph 2,
    Section 4.5)


    - Flagged spacing items (Lines 197, 252, 256 and 260)








    Abstract - ok





    Section 1: Introduction - ok





    Section 1.1: Applicability - ok





    Section 2: Terminology - ok





    Section 3: Overview - ok





    paragraph 2: their addresses may be manually configured or they may


       be found by some other means defined in a later specification


    ** This text is not quite clear.  Is it the author’s intention that
    the reader assume the other means will be part of a specific DNCP
    profile specification, a revision of the DNCP document or a
    different type of document.? ***





    Section 4: Operation





    Section 4.1: Hash Tree - ok





    Section 4.2: Data Transport 





    Paragraph 4 / Part “Multicast+Unicast”


     <old> It is used to send Network State TLVs every now and


          then, as specified in Section 4.3


    <suggested> It is used to send Network State TLVs
    periodically, as specified in Section 4.3


    <reason>  Avoids using an idiom to express sending frequency
    in text.





    Section 4.3: Trickle-Driven Status Update - ok





    Section 4.4: Processing of Received TLVs - ok





    Section 4.5. Adding and Removing Peers - ok





    Section 5: Data Model - ok





    Section 6: Optional Extensions - ok





    Section 6.1: Keep Alives





    Section 6.1.1 Data Model Additions - ok





    Section 6.1.2 Per-Endpoint Keep-Alives - ok





    Section 6.1.3: Per-Peer Periodic Keep-Alives - ok





    Section 6.1.4: Received TLV Processing Additions - ok





    Section 6.1.5 Peer Removal





    Section 6.2 Support for Dense Multicast-Enabled Links





    Section 7.0 Type-Length-Value Objects





    TLV Sections - appear ok





    Section 8 Security and Trust Management - ok





    Section 8.1 Pre-Shared Kay Trust Method - ok





    ** Would it be within the DNCP document to discuss how PSKs are
    stored (as to not be externally accessed) or would it be to the
    profile to defined that level? ***





    Section 8.2 PKI Based Trust Method - ok





    Section 8.3 Certificate Based-Trust Consensus Method - ok





    Section 8.3.1 Trust Verdicts - ok





    Section 8.3.2 Trust Cache - ok





    Section 8.3.3 Announcement of Verdicts 





    Section 8.3.4 Bootstrap Ceremonies - ok





    Section 8.3.4.1 Trust by Identification - ok





    Section 8.3.4.2 Preconfigured Trust - ok





    Section 8.3.4.3 Trust on Button Press - ok





    Section 8.3.4.4 Trust on First Use - ok





    Section 9 DNCP Profile-Specific Definitions - ok





    Section 10 Security Considerations - ok














    regards,





    Victor Kuarsingh