Last Call Review of draft-ietf-i2nsf-sdn-ipsec-flow-protection-08
review-ietf-i2nsf-sdn-ipsec-flow-protection-08-yangdoctors-lc-bjorklund-2020-08-24-00

Request Review of draft-ietf-i2nsf-sdn-ipsec-flow-protection
Requested revision No specific revision (document currently at 14)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2020-08-24
Requested 2020-08-05
Requested by Yoav Nir
Authors Rafael Marin-Lopez , Gabriel Lopez-Millan , Fernando Pereniguez-Garcia
I-D last updated 2020-08-24
Completed reviews Yangdoctors Early review of -04 by Martin Björklund (diff)
Yangdoctors Last Call review of -08 by Martin Björklund (diff)
Opsdir Last Call review of -08 by Menachem Dodge (diff)
Secdir Last Call review of -08 by Derek Atkins (diff)
Genart Last Call review of -08 by Mohit Sethi (diff)
Secdir Telechat review of -12 by Derek Atkins (diff)
Comments 
This document has gone through early review. Now that it's gone through WGLC, we'd like another one.

This was suggested by Christian Hopps
Assignment Reviewer Martin Björklund
State Completed
Request Last Call review on draft-ietf-i2nsf-sdn-ipsec-flow-protection by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/cyy6GdtOXvbr3WuSlbSAR-STaPw
Reviewed revision 08 (document currently at 14)
Result Ready w/nits
Completed 2020-08-24
review-ietf-i2nsf-sdn-ipsec-flow-protection-08-yangdoctors-lc-bjorklund-2020-08-24-00
I did an early YANG Doctor's review of this draft.  Most of my
comments then have been addressed in this version.

Comments:

o  As I wrote in my early review, the RFC editor enforces a common
   format of YANG modules, so it is better to adhere to this format
   before sending the draft to the RFC editor.  Use

     pyang -f yang --yang-line-length 69 <FILE>

   to get a consistent look-and-feel for your module.

   (You will have to manually re-flow description statements after
   this.)


o  There are some leafs that are optional in the model, but w/o a
   default value and w/o an explanation of what happens if that leaf
   is not set.  You should find those and either make them mandatory,
   add a default value, or explain what it means when it isn't set.
   As an example,
   /ipsec-ike/pad/pad-entrypeer-authenticatin/pre-shared/secret
   is optional.  I suspect that this leaf needs to be mandatory.
   Another example is the leaf espencap.


/martin