Early Review of draft-ietf-i2rs-yang-l2-network-topology-04
review-ietf-i2rs-yang-l2-network-topology-04-rtgdir-early-rogge-2018-03-25-00

Request Review of draft-ietf-i2rs-yang-l2-network-topology
Requested rev. no specific revision (document currently at 06)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2018-03-19
Requested 2018-03-07
Requested by Susan Hares
Other Reviews Rtgdir Early review of -02 by Henning Rogge (diff)
Yangdoctors Early review of -04 by Ladislav Lhotka (diff)
Comments
It would be helpful to have the review done before the I2RS meeting at IETF 101
Review State Completed
Reviewer Henning Rogge
Review review-ietf-i2rs-yang-l2-network-topology-04-rtgdir-early-rogge-2018-03-25
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/eIPHD_hIJ2yyqZwY05beD3h4-ok
Reviewed rev. 04 (document currently at 06)
Review result Ready
Draft last updated 2018-03-25
Review completed: 2018-03-25

Review
review-ietf-i2rs-yang-l2-network-topology-04-rtgdir-early-rogge-2018-03-25

Hello,

Amy Yemin asked me to review draft-ietf-i2rs-yang-l2-network-topology
revision 4.

I already did a review of revision 2, so I will focus on the
differences between the two versions.


I really like the fact that the physical layer-2 address was moved
into the general description of nodes and termination points. Common
fields like this make it easier to write application and services that
don't need to be updated with each new special case added to the
format.

I also think it is a good style that the "legacy" case for termination
points was moved to the end of the list.


I think revision 4 resolves the minor issues I had with draft revision 2.

Henning Rogge




On Tue, Mar 13, 2018 at 7:35 AM, Yemin (Amy) <amy.yemin@huawei.com> wrote:
> Thank you, Henning.
>
>
>
> Amy
>
> From: Henning Rogge [mailto:hrogge@gmail.com]
> Sent: Tuesday, March 13, 2018 1:43 PM
> To: Yemin (Amy) <amy.yemin@huawei.com>
> Subject: Re: Could you do the review´╝č//RE: rtgdir Early Review requested:
> draft-ietf-i2rs-yang-l2-network-topology
>
>
>
> Yes, I will do so.
>
>
>
> Henning
>
>
>
> Am 13.03.2018 04:44 schrieb "Yemin (Amy)" <amy.yemin@huawei.com>:
>
> Hi Henning,
>
> Could you please reply if you can do the review or not?
> Thanks.
>
> Amy
> -----Original Message-----
> From: Yemin (Amy)
> Sent: Thursday, March 08, 2018 11:53 AM
> To: 'Henning Rogge' <hrogge@gmail.com>
> Cc: 'Susan Hares' <skh@ndzh.com>; Jonathan Hardwick
> <jonathan.hardwick@metaswitch.com>
> Subject: RE: rtgdir Early Review requested:
> draft-ietf-i2rs-yang-l2-network-topology
>
> Hi Henning,
>
> Could you re-review the draft-ietf-i2rs-yang-l2-network-topology again?
> https://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-l2-network-topology/
>
> This is an early review request.  There is some guidance and a template
> here.
> https://trac.ietf.org/trac/rtg/wiki/RtgDirGuidance
>
> The deadline for comments is March 19.  Please let me know if you can do it,
> or not.
>
> Many thanks
> Amy
>
> -----Original Message-----
> From: Susan Hares [mailto:skh@ndzh.com]
> Sent: Thursday, March 08, 2018 12:56 AM
> To: Jonathan Hardwick <jonathan.hardwick@metaswitch.com>; Yemin (Amy)
> <amy.yemin@huawei.com>
> Subject: rtgdir Early Review requested:
> draft-ietf-i2rs-yang-l2-network-topology
>
>
> Early review of: draft-ietf-i2rs-yang-l2-network-topology (no specific
> version)
> Deadline: 2018-03-19
> Requested by: Susan Hares
>
> https://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-l2-network-topology/reviewrequest/10234/
>
> rtgdir Early Review requested: draft-ietf-i2rs-yang-l2-network-topology
>
> It would be helpful to have the review done before the I2RS meeting at IETF
> 101
>