Early Review of draft-ietf-i2rs-yang-l2-network-topology-04
review-ietf-i2rs-yang-l2-network-topology-04-yangdoctors-early-lhotka-2018-05-02-00

Request Review of draft-ietf-i2rs-yang-l2-network-topology
Requested rev. no specific revision (document currently at 06)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2018-03-21
Requested 2018-03-07
Requested by Susan Hares
Other Reviews Rtgdir Early review of -02 by Henning Rogge (diff)
Rtgdir Early review of -04 by Henning Rogge (diff)
Comments
It would be helpful to have the review done before the I2RS meeting at IETF 101
Review State Completed
Reviewer Ladislav Lhotka
Review review-ietf-i2rs-yang-l2-network-topology-04-yangdoctors-early-lhotka-2018-05-02
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/EWz9atq6XX8LLCTXpJ8SYJo3Rcg
Reviewed rev. 04 (document currently at 06)
Review result Ready
Draft last updated 2018-05-02
Review completed: 2018-05-02

Review
review-ietf-i2rs-yang-l2-network-topology-04-yangdoctors-early-lhotka-2018-05-02

This draft and YANG modules contained therein fit into the framework of I2RS network topology models. I have no substantial comments, from the YANG point of view this document is ready to be published.

Comments and questions:

1. What is the purpose of the 'flag-type' type and 'flag-identity' identity? There are no identities derived from the latter.

2. Some descriptions overuse capitalization. For example, instead of 'VLAN Name' I would suggest 'VLAN name'.

3. An example of an instance document in an appendix would be very helpful.