Last Call Review of draft-ietf-idr-bgp-extended-messages-35
review-ietf-idr-bgp-extended-messages-35-secdir-lc-salz-2019-08-02-00

Request Review of draft-ietf-idr-bgp-extended-messages
Requested rev. no specific revision (document currently at 36)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2019-07-18
Requested 2019-07-02
Authors Randy Bush, Keyur Patel, David Ward
Draft last updated 2019-08-02
Completed reviews Rtgdir Early review of -11 by Brian Weis (diff)
Genart Last Call review of -33 by Paul Kyzivat (diff)
Opsdir Last Call review of -33 by Jouni Korhonen (diff)
Secdir Last Call review of -35 by Rich Salz (diff)
Rtgdir Telechat review of -33 by Himanshu Shah (diff)
Assignment Reviewer Rich Salz
State Completed
Review review-ietf-idr-bgp-extended-messages-35-secdir-lc-salz-2019-08-02
Posted at https://mailarchive.ietf.org/arch/msg/secdir/GDT_DQxL8y7PNpdfD2zGDBvBmH0
Reviewed rev. 35 (document currently at 36)
Review result Ready
Review completed: 2019-08-02

Review
review-ietf-idr-bgp-extended-messages-35-secdir-lc-salz-2019-08-02

This is the secdir review, intended for the security AD's.  Others should treat this as normal last-call comments.

This describes a BGP extension code to increase the size of BGP messages. It nicely explains deployment issues (if a BGP node doesn't understand the extension), and security issues.

The extension is disallowed for two operations, although only one has a rationale; it was left to reader to intuit that KEEPALIVE doesn't need the longer size. I suggest making that explicit.  That is a nit.

Looks good; ship it.