Last Call Review of draft-ietf-idr-bgp-prefix-sid-21
review-ietf-idr-bgp-prefix-sid-21-genart-lc-yee-2018-06-13-00

Request Review of draft-ietf-idr-bgp-prefix-sid
Requested rev. no specific revision (document currently at 27)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2018-06-12
Requested 2018-05-29
Authors Stefano Previdi, Clarence Filsfils, Acee Lindem, Arjun Sreekantiah, Hannes Gredler
Draft last updated 2018-06-13
Completed reviews Rtgdir Early review of -04 by Christian Hopps (diff)
Rtgdir Early review of -04 by Bruno Decraene (diff)
Secdir Early review of -13 by Brian Weis (diff)
Rtgdir Telechat review of -11 by Tony Przygienda (diff)
Genart Last Call review of -10 by Peter Yee (diff)
Genart Telechat review of -11 by Peter Yee (diff)
Rtgdir Last Call review of -21 by Bruno Decraene (diff)
Genart Last Call review of -21 by Peter Yee (diff)
Assignment Reviewer Peter Yee
State Completed
Review review-ietf-idr-bgp-prefix-sid-21-genart-lc-yee-2018-06-13
Reviewed rev. 21 (document currently at 27)
Review result Ready with Nits
Review completed: 2018-06-13

Review
review-ietf-idr-bgp-prefix-sid-21-genart-lc-yee-2018-06-13

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-idr-bgp-prefix-sid-21
Reviewer: Peter Yee
Review Date: 2018-06-12
IETF LC End Date: 2018-06-12
IESG Telechat date: Not scheduled for a telechat

Summary: This document is ready for publication, although there are a few nits that should be corrected prior to publication.  I am not a routing expert, so I cannot vouch for the correctness of this specification, but it otherwise appears consistent and reflect s the many iterations it has undergone.

Major issues: None.

Minor issues: None

Nits/editorial comments:

General:

Expand uncommon acronyms on first use.  (See: https://www.rfc-editor.org/materials/abbrev.expansion.txt.).  Acronyms need expansion include: AS, ECMP, and EBGP.

Specific:

Page 3, 7th paragraph, last sentence: actually, this isn’t a complete sentence.  I’m not sure what you wanted to do with the fragment.

Page 5, 2nd full paragraph, last sentence: change “prefix-SID” to “BGP Prefix-SID” to make usage in the remainder of the document.

Page 7, Section 3.2, 2nd bullet item: insert “positive” before “multiple”.

Page 9, last paragraph, 1st sentence: delete “to”.

Page 12, 1st paragraph after the (unlabeled) Value/Type/Reference table, last sentence: insert “ Prefix” before “-SID”.

Page 12, 2nd paragraph after the (unlabeled) Value/Type/Reference table, last sentence: insert “ Prefix” before “-SID”.