Last Call Review of draft-ietf-idr-bgp-sendholdtimer-13
review-ietf-idr-bgp-sendholdtimer-13-secdir-lc-wallace-2024-07-28-00
| Request | Review of | draft-ietf-idr-bgp-sendholdtimer |
|---|---|---|
| Requested revision | No specific revision (document currently at 15) | |
| Type | IETF Last Call Review | |
| Team | Security Area Directorate (secdir) | |
| Deadline | 2024-07-29 | |
| Requested | 2024-07-08 | |
| Authors | Job Snijders , Ben Cartwright-Cox , Yingzhen Qu | |
| I-D last updated | 2024-11-06 (Latest revision 2024-08-06) | |
| Completed reviews |
Genart IETF Last Call review of -13
by Robert Sparks
(diff)
Opsdir IETF Last Call review of -13 by Victor Kuarsingh (diff) Secdir IETF Last Call review of -13 by Carl Wallace (diff) |
|
| Assignment | Reviewer | Carl Wallace |
| State | Completed | |
| Request | IETF Last Call review on draft-ietf-idr-bgp-sendholdtimer by Security Area Directorate Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/secdir/xIhzG-rMgdG-PvQN1hEt67kGFsA | |
| Reviewed revision | 13 (document currently at 15) | |
| Result | Ready | |
| Completed | 2024-07-28 |
review-ietf-idr-bgp-sendholdtimer-13-secdir-lc-wallace-2024-07-28-00
This draft defines the SendHoldtimer and SendHoldTimer_Expires for the BGP state machine. The draft is straightforward and well written but I had one minor nit. In section 3.3, there is a NEW block to be added that begins "If the SendHoldTimer_Expires (Event 29), the local system:". This seems to be incomplete. From similar text in 4271, one fix would be to put the word "occurs" before the comma.