Last Call Review of draft-ietf-isis-sbfd-discriminator-02
review-ietf-isis-sbfd-discriminator-02-opsdir-lc-dodge-2015-11-19-00

Request Review of draft-ietf-isis-sbfd-discriminator
Requested rev. no specific revision
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2015-11-17
Requested 2015-11-10
Other Reviews Secdir Last Call review of -02 by Taylor Yu
Opsdir Last Call review of -02 by Nevil Brownlee
Review State Completed
Reviewer Menachem Dodge
Review review-ietf-isis-sbfd-discriminator-02-opsdir-lc-dodge-2015-11-19
Posted at http://www.ietf.org/mail-archive/web/ops-dir/current/msg01524.html
Reviewed rev. 02
Review result Has Nits
Draft last updated 2015-11-19
Review completed: 2015-11-19

Review
review-ietf-isis-sbfd-discriminator-02-opsdir-lc-dodge-2015-11-19

Hello, 

I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review.  Document editors and WG chairs should treat these comments just like any other last call comments.

This intended status of this document is Standards Track.

This document defines a new sub-TLV of the IS-IS Router Capability TLV to advertise one or more S-BFD Discriminators.

NITS

====

The NITS Tool founds the following warnings:

 == The document seems to contain a disclaimer for pre-RFC5378 work, but was
     first submitted on or after 10 November 2008.  The disclaimer is usually
     necessary only for documents that revise or obsolete older RFCs, and that
     take significant amounts of text from those RFCs.  If you can contact all
     authors of the source material and they are willing to grant the BCP78
     rights to the IETF Trust, you can and should remove the disclaimer. 
     Otherwise, the disclaimer is needed and you can ignore this comment. 
     (See the Legal Provisions document at
     

http://trustee.ietf.org/license-info

 for more information.)

 == Outdated reference: A later version (-05) exists of
     draft-ietf-bfd-seamless-base-04

-----------------------------------------

In addition the following sentence may need clarification: 

"

When multiple S-BFD discriminators are 

advertised how a given discriminator is mapped to a specific use case 

is out of scope for this document."

It was not clear to me whether this is defined or will be defined in a different document or whether this is left open for each implementation.

------------------------------------

Other than the above, I have no issues with the document.

Thank you kindly,

Menachem Dodge