Last Call Review of draft-ietf-isis-sr-yang-24
review-ietf-isis-sr-yang-24-secdir-lc-roca-2025-02-07-00

Request Review of draft-ietf-isis-sr-yang
Requested revision No specific revision (document currently at 31)
Type IETF Last Call Review
Team Security Area Directorate (secdir)
Deadline 2025-01-30
Requested 2025-01-16
Authors Stephane Litkowski , Yingzhen Qu , Acee Lindem , Ing-Wher (Helen) Chen , Jeff Tantsura
I-D last updated 2025-12-09 (Latest revision 2025-05-06)
Completed reviews Yangdoctors IETF Last Call review of -19 by Reshad Rahman (diff)
Rtgdir IETF Last Call review of -17 by Shuping Peng (diff)
Yangdoctors IETF Last Call review of -13 by Jan Lindblad (diff)
Secdir IETF Last Call review of -24 by Vincent Roca (diff)
Genart IETF Last Call review of -23 by Behcet Sarikaya (diff)
Assignment Reviewer Vincent Roca
State Completed
Request IETF Last Call review on draft-ietf-isis-sr-yang by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/U0kGy2NafH8jRM4kjjtG5eH1K64
Reviewed revision 24 (document currently at 31)
Result Has nits
Completed 2025-02-07
review-ietf-isis-sr-yang-24-secdir-lc-roca-2025-02-07-00
Hello,

I have reviewed this document as part of the security directorate’s ongoing
effort to review all IETF documents being processed by the IESG. These
comments were written primarily for the benefit of the security area
directors. Document editors and WG chairs should treat these comments just
like any other last call comments.

Summary: has nits

The security considerations section follows the usual guidelines for YANG modules.
However, I have two comments:
- the last sentence of the 3rd paragraph:
    "These are the subtrees and data nodes and their sensitivity/vulnerability:"
suggests that the sensitivity and vulnerability of the 4 data nodes be discussed.
Yet I see nothing.

-- the sentence:
    "And the augmentations to the ISIS link state database." 
is incomplete.

Regards,
Vincent