Telechat Review of draft-ietf-l2vpn-evpn-10
|Requested rev.||no specific revision (document currently at 11)|
|Team||General Area Review Team (Gen-ART) (genart)|
Secdir Last Call review of -08 by Hilarie Orman (diff)
Opsdir Last Call review of -08 by Dan Romascanu (diff)
|Reviewed rev.||10 (document currently at 11)|
|Review result||Ready with Issues|
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-l2vpn-evpn-10 Reviewer: Martin Thomson Review Date: 2014-10-16 IETF LC End Date: past IESG Telechat date: 2014-10-16 Summary: I found no major issues here, but I'm not able to give this proper time to do this justice. I have some comments, but these need to be considered in context of the time I've spent on this. I'm guessing a week might be adequate, but that's time I don't have for GenART. Issues: I found the overview in Section 4 to be very...wooly. It launches straight into alphabet soup, but didn't manage to identify what it was that the document was trying to achieve, vs. what already exists. It certainly raises questions: is this document going to address the issue of how MAC learning is populated on devices in networks attached to CE? Is it going to deal with (MAC) learning on the PE and CE equipment? What information does the CE really need at the MAC layer to do its job? The information provided is definitely not enough to make sense of the remainder of the document. Maybe that's just a shortcoming in my own education; this subject is well outside of my field. I also found the sudden introduction of a bag of protocol elements without context very difficult to process. So an ESI identifies an EVPN? What do I do with one? In section 5, why is there not some sort of registry for the ESI Types that are defined here? Section 6: An Ethernet Tag ID is a 32-bit field containing either a 12-bit or a 24-bit identifier that identifies a particular broadcast domain (e.g., a VLAN) in an EVPN Instance. How do I distinguish one from t'other? Nits: Please check for expansion on first use for acronyms. Maybe it's OK to not expand LSP or MPLS, but I think that there are others that need work. Please provide references on first use of a new concept. I have no idea what a BGP NLRI is, and finding out is made more difficult by this: This document defines a new BGP NLRI, called the EVPN NLRI.