Skip to main content

Telechat Review of draft-ietf-lamps-cms-update-alg-id-protect-03
review-ietf-lamps-cms-update-alg-id-protect-03-genart-telechat-yee-2020-08-25-00

Request Review of draft-ietf-lamps-cms-update-alg-id-protect
Requested revision No specific revision (document currently at 05)
Type Telechat Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2020-08-25
Requested 2020-08-19
Authors Russ Housley
I-D last updated 2020-08-25
Completed reviews Secdir Last Call review of -03 by Robert Sparks (diff)
Genart Telechat review of -03 by Peter E. Yee (diff)
Assignment Reviewer Peter E. Yee
State Completed
Request Telechat review on draft-ietf-lamps-cms-update-alg-id-protect by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/fYss1GCSiOw7RY5ElA1wQryZgjU
Reviewed revision 03 (document currently at 05)
Result Ready w/nits
Completed 2020-08-25
review-ietf-lamps-cms-update-alg-id-protect-03-genart-telechat-yee-2020-08-25-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-cms-update-alg-id-protect-03
Reviewer: Peter Yee
Review Date: 2020-08-25
IETF LC End Date: 2020-08-10
IESG Telechat date: 2020-08-27

Summary: This update to CMS (RFC 5262) attempts to prevent algorithm
substitution attacks on the hash algorithms. The changes seems reasonable, with
one of them already being specified in RFC 6211. There are a few nits that
should be cleared up prior to publication. [Ready with Nits]

Major issues: None

Minor issues: None

Nits/editorial comments:

Page 2, section 1, 2nd paragraph, last sentence: change "associate" to
"associated".

Page 4, 1st NEW block, 4th sentence: insert "the" before "signedAttrs field".

Page 5, section 3.5, 2nd paragraph, 1st sentence: insert "the" before "same
digest".

Page 5, section 4 title: change "Recommend" to "Recommended" for parallel
construction with the section 3 title.

Page 6, ADD block: delete the first "known".

Page 6, section 6, 3rd paragraph, 5th sentence: change "signalling" to
"signaling".