Last Call Review of draft-ietf-lamps-lightweight-cmp-profile-14
review-ietf-lamps-lightweight-cmp-profile-14-genart-lc-halpern-2022-10-14-00

Request Review of draft-ietf-lamps-lightweight-cmp-profile
Requested revision No specific revision (document currently at 21)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2022-10-24
Requested 2022-10-10
Authors Hendrik Brockhaus , David von Oheimb , Steffen Fries
I-D last updated 2022-10-14
Completed reviews Dnsdir Last Call review of -14 by David Blacka (diff)
Genart Last Call review of -14 by Joel M. Halpern (diff)
Artart Last Call review of -14 by Robert Sparks (diff)
Intdir Telechat review of -15 by Sheng Jiang (diff)
Iotdir Telechat review of -15 by Niklas Widell (diff)
Assignment Reviewer Joel M. Halpern
State Completed
Request Last Call review on draft-ietf-lamps-lightweight-cmp-profile by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/e5IebZc2HCpuzEdIq8vETvhPJ94
Reviewed revision 14 (document currently at 21)
Result Ready
Completed 2022-10-14
review-ietf-lamps-lightweight-cmp-profile-14-genart-lc-halpern-2022-10-14-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-lightweight-cmp-profile-14
Reviewer: Joel Halpern
Review Date: 2022-10-13
IETF LC End Date: 2022-10-24
IESG Telechat date: Not scheduled for a telechat

Summary: This document is ready for publicationa s a Proposed Standard

Major issues:

Minor issues:
    In section 4.1.1 (Enrolling an End Entity to a New PKI), in the description
    of the ir message, some fields are listed as optional, with text saying
    roughly required in case A, omitted in case B.    Which makes sense. 
    However, the subjectPublicKey is listed as REQUIRED, even though the text
    only says it is needed for locally generated keys.  The text does not deal
    with whether it should be omitted or Null-DN or? for centrally generated
    keys?  Section 4.1.6 does deal with this, but I am asking because the field
    is marked in the 4.1.1 ir as being REQUIRED.

Nits/editorial comments: